Conversation
ccschmitz-launchdarkly
approved these changes
Feb 23, 2026
Contributor
ccschmitz-launchdarkly
left a comment
There was a problem hiding this comment.
Thank you for fixing this! One thought on the design of this and trying to avoid calling these internal methods, but I like the approach overall and think this is a great improvement!
Contributor
|
Some relevant discussion around this functionality in the instrumentation-fetch repo: open-telemetry/opentelemetry-js#5293 Apparently they used to support this, but eliminated it because of potential memory pressure: open-telemetry/opentelemetry-js#5281 |
Contributor
Author
ccschmitz-launchdarkly
approved these changes
Feb 25, 2026
ddf6f6c to
a195cf6
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Merged
Vadman97
pushed a commit
that referenced
this pull request
Feb 26, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>observability: 1.0.3</summary> ## [1.0.3](observability-1.0.2...observability-1.0.3) (2026-02-26) ### Dependencies * The following workspace dependencies were updated * dependencies * highlight.run bumped to 9.27.1 </details> <details><summary>session-replay: 1.0.3</summary> ## [1.0.3](session-replay-1.0.2...session-replay-1.0.3) (2026-02-26) ### Dependencies * The following workspace dependencies were updated * dependencies * highlight.run bumped to 9.27.1 </details> <details><summary>highlight.run: 9.27.1</summary> ## [9.27.1](highlight.run-9.27.0...highlight.run-9.27.1) (2026-02-26) ### Bug Fixes * improve network response capture ([#379](#379)) ([43d2dc3](43d2dc3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping: version bumps and changelog updates only, with no functional code changes in this diff. > > **Overview** > Updates release metadata to publish new patch versions: `@launchdarkly/observability` and `@launchdarkly/session-replay` to `1.0.3`, and `highlight.run` to `9.27.1`. > > Changelogs are updated to reflect the dependency bump (and `highlight.run`’s noted bug fix: improved network response capture), and `.release-please-manifest.json` is updated accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c5cdc12. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
abelonogov-ld
added a commit
that referenced
this pull request
Feb 27, 2026
* main: chore: release main (#396) fix: Android span e2e tests (#397) fix: improve network response capture (#379) feat: initial upload of mobile-dotnet (#393) chore: release main (#394) fix: Fix event sorting in session replay export (#392) fix: Touch move event buffering using wrong clock and mismatched constants (#391)
abelonogov-ld
added a commit
that referenced
this pull request
Feb 28, 2026
* main: feat: Optional Jet Compose (#402) feat: Android Incremental Image Diff compression (#390) chore: add CLAUDE.md (#398) chore: release main (#400) fix: correct react native session replay build step (#399) chore: release main (#396) fix: Android span e2e tests (#397) fix: improve network response capture (#379) # Conflicts: # sdk/@launchdarkly/mobile-dotnet/.vscode/tasks.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Improve capture of HTTP response bodies for long-running requests.
Fix requestResponseSanitizer logic not working correctly with OTel code.
How did you test this change?
local SDK build with example app

testing sanitizer


Are there any deployment considerations?
Note
Medium Risk
Touches the browser OTel span lifecycle/export path and adds async coordination for response-body capture, which could affect span export timing and memory usage under load.
Overview
Fixes fetch span response-body capture by coordinating the async
Responsebody clone/read with span export:applyCustomAttributesOnSpanstores a per-span promise inpendingResponseAttributes, andCustomBatchSpanProcessor.onEnd()awaits it (and now also flushes/cleans up onshutdown/forceFlush).Adds
applyRequestResponseSanitizerfor the OTel path and runs it for both fetch and XHR spans (before and after response attributes are added), including honoring anullreturn by marking spans withhighlight.record=falseand skipping body capture to avoid leaks.Expands the React Router e2e
http-testpage with new response-body capture and high-concurrency/memory-pressure test buttons, and reformats.vscode/JSON config files in the mobile .NET sample.Written by Cursor Bugbot for commit 78541bc. This will update automatically on new commits. Configure here.