feat: Add BrushIcon to Icon Collection#1502
Open
icoderarely wants to merge 4 commits intolayer5io:masterfrom
Open
feat: Add BrushIcon to Icon Collection#1502icoderarely wants to merge 4 commits intolayer5io:masterfrom
icoderarely wants to merge 4 commits intolayer5io:masterfrom
Conversation
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new BrushIcon component and its corresponding index file. Review feedback indicates that the SVG path provided actually represents a pencil icon rather than a brush, and a correction has been suggested. Additionally, the icon should be exported from the main icons index file to ensure it is accessible throughout the application.
| xmlns="http://www.w3.org/2000/svg" | ||
| {...props} | ||
| > | ||
| <path d="M20.71 7.04c.39-.39.39-1.02 0-1.41l-2.34-2.34c-.39-.39-1.02-.39-1.41 0l-1.83 1.83 3.75 3.75 1.83-1.83zM3 17.25V21h3.75L17.81 9.94l-3.75-3.75L3 17.25z" /> |
Contributor
There was a problem hiding this comment.
The SVG path provided corresponds to the 'Edit' (pencil) icon, which is already present in the icon collection. If the intention is to add a 'Brush' icon, please use the correct path from the Material Design set.
Suggested change
| <path d="M20.71 7.04c.39-.39.39-1.02 0-1.41l-2.34-2.34c-.39-.39-1.02-.39-1.41 0l-1.83 1.83 3.75 3.75 1.83-1.83zM3 17.25V21h3.75L17.81 9.94l-3.75-3.75L3 17.25z" /> | |
| <path d="M7 14c-1.1 0-2 .9-2 2 0 1.1.9 2 2 2s2-.9 2-2c0-1.1-.9-2-2-2zm3.71-3.12c-.39-.39-1.02-.39-1.41 0L3.27 16.9c-.39.39-.39 1.02 0 1.41.39.39 1.02.39 1.41 0l6.03-6.03c.38-.39.38-1.03 0-1.4zM21 3h-3c-.55 0-1 .45-1 1v3c0 .55.45 1 1 1h3c.55 0 1-.45 1-1V4c0-.55-.45-1-1-1zm-8 4h-3c-.55 0-1 .45-1 1v3c0 .55.45 1 1 1h3c.55 0 1-.45 1-1V8c0-.55-.45-1-1-1z" /> |
| @@ -0,0 +1 @@ | |||
| export { default as BrushIcon } from './BrushIcon'; | |||
Contributor
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
rishiraj38
suggested changes
May 7, 2026
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
Author
|
@rishiraj38 thank you for the suggested changes, I have committed the update |
rishiraj38
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #1489
Signed commits