Skip to content

[Merged by Bors] - feat(CategoryTheory/Abelian/Preradical): introduce and characterize radicals#35586

Closed
farmanb wants to merge 37 commits intoleanprover-community:masterfrom
farmanb:radical
Closed

[Merged by Bors] - feat(CategoryTheory/Abelian/Preradical): introduce and characterize radicals#35586
farmanb wants to merge 37 commits intoleanprover-community:masterfrom
farmanb:radical

Conversation

@farmanb
Copy link
Copy Markdown
Contributor

@farmanb farmanb commented Feb 20, 2026

Following Stenström, a preradical Φ is called radical if it coincides with its self colon. We encode this as the existence of an isomorphism Φ.colon Φ ≅ Φ. We then prove a basic characterization of radical preradicals in terms of the vanishing of Φ.r on Φ.quotient.


@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 20, 2026
@github-actions
Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@farmanb farmanb changed the title feat(CategoryTheory/Abelian/Preradical): introduce and characterize radicals. feat(CategoryTheory/Abelian/Preradical): introduce and characterize radicals Feb 20, 2026
@github-actions github-actions bot added the t-category-theory Category theory label Feb 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 20, 2026

PR summary 6e9770b320

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.CategoryTheory.Abelian.Preradical.Radical (new file) 836

Declarations diff

+ Radical
+ instance (Φ : Radical C) : IsIso (Preradical.toColon Φ.obj Φ.obj) := Φ.property
+ isRadical
+ isRadical_iff_isIso
+ isRadical_iff_isZero
+ isZero

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions
Copy link
Copy Markdown

🚨 PR Title Needs Formatting

Please update the title to match our commit style conventions.

Errors from script:

error: the PR title should not end with a full stop
Details on the required title format

The title should fit the following format:

<kind>(<optional-scope>): <subject>

<kind> is:

  • feat (feature)
  • fix (bug fix)
  • doc (documentation)
  • style (formatting, missing semicolons, ...)
  • refactor
  • test (when adding missing tests)
  • chore (maintain)
  • perf (performance improvement, optimization, ...)
  • ci (changes to continuous integration, repo automation, ...)

<optional-scope> is a name of module or a directory which contains changed modules.
This is not necessary to include, but may be useful if the <subject> is insufficient.
The Mathlib directory prefix is always omitted.
For instance, it could be

  • Data/Nat/Basic
  • Algebra/Group/Defs
  • Topology/Constructions

<subject> has the following constraints:

  • do not capitalize the first letter
  • no dot(.) at the end
  • use imperative, present tense: "change" not "changed" nor "changes"

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 20, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 27, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 27, 2026
…so fixed the name (isRadical_iff_isZero) in main results.
@farmanb
Copy link
Copy Markdown
Contributor Author

farmanb commented Mar 12, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 12, 2026
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 12, 2026
@joelriou
Copy link
Copy Markdown
Contributor

There is still one suggestion of modification.

@farmanb
Copy link
Copy Markdown
Contributor Author

farmanb commented Mar 12, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 12, 2026
Copy link
Copy Markdown
Contributor

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly style nitpicks on my side.

@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 13, 2026
@farmanb
Copy link
Copy Markdown
Contributor Author

farmanb commented Mar 13, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 13, 2026
@joelriou joelriou added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 15, 2026
@farmanb
Copy link
Copy Markdown
Contributor Author

farmanb commented Mar 15, 2026

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 15, 2026
@joelriou
Copy link
Copy Markdown
Contributor

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Mar 16, 2026
mathlib-bors bot pushed a commit that referenced this pull request Mar 16, 2026
…adicals (#35586)

Following Stenström, a preradical `Φ` is called radical if it coincides with its self colon. We encode this as the existence of an isomorphism `Φ.colon Φ ≅ Φ`.  We then prove a basic characterization of radical preradicals in terms of the vanishing of `Φ.r` on `Φ.quotient`.

Co-authored-by: blake-farman <blake.farman@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Mar 16, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Abelian/Preradical): introduce and characterize radicals [Merged by Bors] - feat(CategoryTheory/Abelian/Preradical): introduce and characterize radicals Mar 16, 2026
@mathlib-bors mathlib-bors bot closed this Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants