Skip to content

[Merged by Bors] - perf(LinearAlgebra/RootSystem/GeckConstruction/Relations): get rid of some aesop#35587

Closed
GrigorenkoPV wants to merge 2 commits intoleanprover-community:masterfrom
GrigorenkoPV:aesop
Closed

[Merged by Bors] - perf(LinearAlgebra/RootSystem/GeckConstruction/Relations): get rid of some aesop#35587
GrigorenkoPV wants to merge 2 commits intoleanprover-community:masterfrom
GrigorenkoPV:aesop

Conversation

@GrigorenkoPV
Copy link
Contributor


On my machine this gets it down from 19s to 13s

Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Feb 20, 2026
@github-actions
Copy link

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

PR summary 2a33a10667

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 20, 2026
@vihdzp
Copy link
Collaborator

vihdzp commented Feb 21, 2026

!bench

@leanprover-radar
Copy link

leanprover-radar commented Feb 21, 2026

Benchmark results for 1256e50 against 2a33a10 are in! @vihdzp

  • 🟥 build//instructions: +35.5G (+0.02%)

Medium changes (1✅)

  • build/module/Mathlib.LinearAlgebra.RootSystem.GeckConstruction.Relations//instructions: -9.0G (-9.26%)

Small changes (1✅, 1🟥)

  • 🟥 build/module/Mathlib.Data.Multiset.Fold//instructions: +541.7M (+8.43%)
  • build/module/Mathlib.Lean.Name//instructions: -241.6M (-7.12%)

Copy link
Collaborator

@vihdzp vihdzp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These all seem like unambiguous improvements in both performance and style.

@vihdzp
Copy link
Collaborator

vihdzp commented Feb 21, 2026

I'm quite surprised by the bench results... maybe it's just noise? Perhaps it's worth re-running in a day or so.

@grunweg
Copy link
Contributor

grunweg commented Feb 21, 2026

I think the benchmark results are mostly noise --- but notice that the only modified file speeds up.

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 21, 2026
Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
@GrigorenkoPV
Copy link
Contributor Author

-awaiting-author

@github-actions github-actions bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label Feb 21, 2026
@grunweg
Copy link
Contributor

grunweg commented Feb 22, 2026

Thanks!
bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Feb 22, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 22, 2026
… some `aesop` (#35587)

Co-authored-by: Pavel Grigorenko <GrigorenkoPV@ya.ru>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 22, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title perf(LinearAlgebra/RootSystem/GeckConstruction/Relations): get rid of some aesop [Merged by Bors] - perf(LinearAlgebra/RootSystem/GeckConstruction/Relations): get rid of some aesop Feb 22, 2026
@mathlib-bors mathlib-bors bot closed this Feb 22, 2026
@GrigorenkoPV GrigorenkoPV deleted the aesop branch February 22, 2026 15:28
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
… some `aesop` (leanprover-community#35587)

Co-authored-by: Pavel Grigorenko <GrigorenkoPV@ya.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants