[Merged by Bors] - perf(LinearAlgebra/RootSystem/GeckConstruction/Relations): get rid of some aesop#35587
[Merged by Bors] - perf(LinearAlgebra/RootSystem/GeckConstruction/Relations): get rid of some aesop#35587GrigorenkoPV wants to merge 2 commits intoleanprover-community:masterfrom
aesop#35587Conversation
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary 2a33a10667Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
!bench |
|
Benchmark results for 1256e50 against 2a33a10 are in! @vihdzp
Medium changes (1✅)
Small changes (1✅, 1🟥)
|
vihdzp
left a comment
There was a problem hiding this comment.
Thanks! These all seem like unambiguous improvements in both performance and style.
Mathlib/LinearAlgebra/RootSystem/GeckConstruction/Relations.lean
Outdated
Show resolved
Hide resolved
Mathlib/LinearAlgebra/RootSystem/GeckConstruction/Relations.lean
Outdated
Show resolved
Hide resolved
Mathlib/LinearAlgebra/RootSystem/GeckConstruction/Relations.lean
Outdated
Show resolved
Hide resolved
|
I'm quite surprised by the bench results... maybe it's just noise? Perhaps it's worth re-running in a day or so. |
|
I think the benchmark results are mostly noise --- but notice that the only modified file speeds up. |
Co-authored-by: Violeta Hernández Palacios <vi.hdz.p@gmail.com>
|
-awaiting-author |
|
Thanks! |
… some `aesop` (#35587) Co-authored-by: Pavel Grigorenko <GrigorenkoPV@ya.ru>
|
Pull request successfully merged into master. Build succeeded: |
aesopaesop
… some `aesop` (leanprover-community#35587) Co-authored-by: Pavel Grigorenko <GrigorenkoPV@ya.ru>
On my machine this gets it down from 19s to 13s