[Merged by Bors] - chore(RingTheory/AdicCompletion): update the definition of AdicCompletion.map#35595
Closed
BryceT233 wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(RingTheory/AdicCompletion): update the definition of AdicCompletion.map#35595BryceT233 wants to merge 1 commit intoleanprover-community:masterfrom
AdicCompletion.map#35595BryceT233 wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
github-actions
bot
added
the
new-contributor
Welcome new contributor!Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR. Thank you again for joining our community. |
PR summary eeb0516db2Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
mathlib-triage
bot
added
the
maintainer-merge
This was referenced Feb 23, 2026
Member
|
Thanks! bors merge |
mathlib-triage
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
…etion.map` (#35595) This PR extracts the change of the definition of `AdicCompletion.map` from #34936. @Thmoas-Guan expressed interest in using this result, so I am splitting it out here to unblock it.
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
…etion.map` (#35595) This PR extracts the change of the definition of `AdicCompletion.map` from #34936. @Thmoas-Guan expressed interest in using this result, so I am splitting it out here to unblock it.
Contributor
|
Build failed (retrying...): |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
…etion.map` (#35595) This PR extracts the change of the definition of `AdicCompletion.map` from #34936. @Thmoas-Guan expressed interest in using this result, so I am splitting it out here to unblock it.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
AdicCompletion.mapAdicCompletion.map
pfaffelh
pushed a commit
to pfaffelh/mathlib4
that referenced
this pull request
Mar 2, 2026
…etion.map` (leanprover-community#35595) This PR extracts the change of the definition of `AdicCompletion.map` from leanprover-community#34936. @Thmoas-Guan expressed interest in using this result, so I am splitting it out here to unblock it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the change of the definition of
AdicCompletion.mapfrom #34936.@Thmoas-Guan expressed interest in using this result, so I am splitting it out here to unblock it.