Skip to content

[Merged by Bors] - feat(RingTheory/Lasker): second uniqueness theorem for primary decomposition#35599

Closed
tb65536 wants to merge 33 commits intoleanprover-community:masterfrom
tb65536:tb_snduniq
Closed

[Merged by Bors] - feat(RingTheory/Lasker): second uniqueness theorem for primary decomposition#35599
tb65536 wants to merge 33 commits intoleanprover-community:masterfrom
tb65536:tb_snduniq

Conversation

@tb65536
Copy link
Contributor

@tb65536 tb65536 commented Feb 21, 2026

This PR proves the second uniqueness theorem for primary decomposition.


Open in Gitpod

@tb65536 tb65536 added t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory labels Feb 21, 2026
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Feb 21, 2026
@github-actions
Copy link

github-actions bot commented Feb 21, 2026

PR summary 1a8a236018

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.RingTheory.Lasker 1281 1301 +20 (+1.56%)
Import changes for all files
Files Import difference
Mathlib.RingTheory.Lasker 20

Declarations diff

+ comap_localized₀_eq_iInf
+ comap_localized₀_eq_ite
+ image_radical_eq_associated_primes
+ injOn
+ instance (I : N.associatedPrimes) : I.1.IsPrime := I.2.1
+ instance (I : associatedPrimes R M) : I.1.IsPrime := I.2.1
+ mem_associatedPrimes
+ mem_image_radical_colon_iff
- IsMinimalPrimaryDecomposition.image_radical_eq_associated_primes
- IsMinimalPrimaryDecomposition.mem_image_radical_colon_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib-dependent-issues mathlib-dependent-issues bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 21, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 23, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 24, 2026
@mathlib-dependent-issues
Copy link

@tb65536 tb65536 added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 24, 2026
@github-actions github-actions bot removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) large-import Automatically added label for PRs with a significant increase in transitive imports labels Feb 24, 2026
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 24, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 27, 2026
@mathlib-merge-conflicts
Copy link

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 27, 2026
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 4, 2026

✌️ tb65536 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Mar 4, 2026
@tb65536 tb65536 added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 4, 2026
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 4, 2026
@tb65536
Copy link
Contributor Author

tb65536 commented Mar 4, 2026

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Mar 4, 2026
…osition (#35599)

This PR proves the second uniqueness theorem for primary decomposition.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Mar 4, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(RingTheory/Lasker): second uniqueness theorem for primary decomposition [Merged by Bors] - feat(RingTheory/Lasker): second uniqueness theorem for primary decomposition Mar 4, 2026
@mathlib-bors mathlib-bors bot closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants