Skip to content

[Merged by Bors] - chore: deprecate unused norm_cast lemma#35604

Closed
DavidLedvinka wants to merge 3 commits intoleanprover-community:masterfrom
DavidLedvinka:deprecate_lemma
Closed

[Merged by Bors] - chore: deprecate unused norm_cast lemma#35604
DavidLedvinka wants to merge 3 commits intoleanprover-community:masterfrom
DavidLedvinka:deprecate_lemma

Conversation

@DavidLedvinka
Copy link
Collaborator

This lemma does not appear to fire as a norm_cast lemma and outside of norm_cast, Nat.cast_sub should be used instead.

@github-actions
Copy link

PR summary 90f65323f6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for scripts/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-meta Tactics, attributes or user commands label Feb 21, 2026
@fpvandoorn
Copy link
Member

Thanks!

bors merge

@mathlib-triage mathlib-triage bot added the ready-to-merge This PR has been sent to bors. label Feb 22, 2026
mathlib-bors bot pushed a commit that referenced this pull request Feb 22, 2026
This lemma does not appear to fire as a norm_cast lemma and outside of norm_cast, Nat.cast_sub should be used instead.

Co-authored-by: David Ledvinka <dledvinka.ledvinka@mail.utoronto.ca>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 22, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: deprecate unused norm_cast lemma [Merged by Bors] - chore: deprecate unused norm_cast lemma Feb 22, 2026
@mathlib-bors mathlib-bors bot closed this Feb 22, 2026
pfaffelh pushed a commit to pfaffelh/mathlib4 that referenced this pull request Mar 2, 2026
This lemma does not appear to fire as a norm_cast lemma and outside of norm_cast, Nat.cast_sub should be used instead.

Co-authored-by: David Ledvinka <dledvinka.ledvinka@mail.utoronto.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants