Skip to content

[Merged by Bors] - chore(Computability): move TM files to a single folder#35608

Closed
BoltonBailey wants to merge 11 commits intoleanprover-community:masterfrom
BoltonBailey:turing-folder
Closed

[Merged by Bors] - chore(Computability): move TM files to a single folder#35608
BoltonBailey wants to merge 11 commits intoleanprover-community:masterfrom
BoltonBailey:turing-folder

Conversation

@BoltonBailey
Copy link
Copy Markdown
Collaborator

@BoltonBailey BoltonBailey commented Feb 21, 2026

This PR takes files relevant to Turing machines and moves them to a single folder for better organization.

In the process, we do some renaming of these files

  • We remove the "TM" from the front of these files, as it's now redundant.
  • TuringMachine.lean --> TuringMachine/StackTuringMachine.lean
    • (really the key difference between the TM2 model presented in this file, and the TM1 model from the previous, is the introduction of stacks instead of tapes)

I also remove EvalsTo and friends from TuringMachine.Computable, as these in #33291 were moved out of the TM namespace.

#35609 is a follow-up PR to add module deprecations.


Open in Gitpod

@BoltonBailey BoltonBailey added the WIP Work in progress label Feb 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 21, 2026

PR summary aae3b08dc2

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Computability.StateTransition 464 461 -3 (-0.65%)
Import changes for all files
Files Import difference
Mathlib.Computability.TMComputable -963
Mathlib.Computability.TMToPartrec -658
Mathlib.Computability.TMConfig -637
Mathlib.Computability.TuringMachine -504
Mathlib.Computability.PostTuringMachine -475
Mathlib.Computability.Tape -337
Mathlib.Computability.StateTransition -3
Mathlib.Computability.TuringMachine.Tape 337
Mathlib.Computability.TuringMachine.PostTuringMachine 475
Mathlib.Computability.TuringMachine.StackTuringMachine 504
Mathlib.Computability.TuringMachine.Config 637
Mathlib.Computability.TuringMachine.ToPartrec 658
Mathlib.Computability.TuringMachine.Computable 963

Declarations diff

- EvalsTo.refl
- EvalsTo.trans
- EvalsToInTime.refl
- EvalsToInTime.trans

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

note: file Mathlib/Computability/TMComputable.lean` was renamed to `Mathlib/Computability/TuringMachine/Computable.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/Computability/PostTuringMachine.lean` was renamed to `Mathlib/Computability/TuringMachine/PostTuringMachine.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/Computability/Tape.lean` was renamed to `Mathlib/Computability/TuringMachine/Tape.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/Computability/TuringMachine.lean` was renamed to `Mathlib/Computability/TuringMachine/StackTuringMachine.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/Computability/TMConfig.lean` was renamed to `Mathlib/Computability/TuringMachine/Config.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/Computability/TMToPartrec.lean` was renamed to `Mathlib/Computability/TuringMachine/ToPartrec.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

@github-actions github-actions Bot added file-removed A Lean module was (re)moved without a `deprecated_module` annotation t-computability Computability theory (TMs, DFAs, languages, grammars, etc) labels Feb 21, 2026
@BoltonBailey BoltonBailey removed the WIP Work in progress label Feb 21, 2026
@BoltonBailey
Copy link
Copy Markdown
Collaborator Author

Follow up in #35609

@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 27, 2026
@mathlib-merge-conflicts
Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Feb 27, 2026
Copy link
Copy Markdown
Contributor

@Komyyy Komyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Comment thread Mathlib/Computability/TuringMachine/Computable.lean
Comment thread Mathlib.lean
Comment thread Mathlib/Computability/TuringMachine/StackTuringMachine.lean
@Komyyy Komyyy added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 6, 2026
@BoltonBailey BoltonBailey removed the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 6, 2026
Comment thread Mathlib/Computability/TuringMachine/Computable.lean Outdated
Comment thread Mathlib/Computability/TuringMachine/Computable.lean Outdated
@Komyyy Komyyy added the awaiting-author A reviewer has asked the author a question or requested changes. label Mar 7, 2026
BoltonBailey and others added 2 commits March 8, 2026 11:05
Co-authored-by: Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
Co-authored-by: Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
@BoltonBailey BoltonBailey added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Mar 8, 2026
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 8, 2026
Copy link
Copy Markdown
Contributor

@Komyyy Komyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

maintainer delegate

Comment thread Mathlib/Computability/TuringMachine/Config.lean Outdated
Comment thread Mathlib/Computability/TuringMachine/ToPartrec.lean Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 8, 2026

🚀 Pull request has been placed on the maintainer queue by Komyyy.

@mathlib-triage mathlib-triage Bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Mar 8, 2026
BoltonBailey and others added 2 commits March 9, 2026 16:52
Co-authored-by: Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
Co-authored-by: Miyahara Kō <52843868+Komyyy@users.noreply.github.com>
@bryangingechen
Copy link
Copy Markdown
Contributor

Thanks!
bors r+

@mathlib-triage mathlib-triage Bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Mar 10, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Mar 10, 2026
This PR takes files relevant to Turing machines and moves them to a single folder for better organization.

In the process, we do some renaming of these files

* We remove the "TM" from the front of these files, as it's now redundant.
* TuringMachine.lean --> TuringMachine/StackTuringMachine.lean
  * (really the key difference between the TM2 model presented in this file, and the TM1 model from the previous, is the introduction of stacks instead of tapes)

I also remove `EvalsTo` and friends from TuringMachine.Computable, as these in #33291 were moved out of the TM namespace.

#35609 is a follow-up PR to add module deprecations.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Mar 10, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(Computability): move TM files to a single folder [Merged by Bors] - chore(Computability): move TM files to a single folder Mar 10, 2026
@mathlib-bors mathlib-bors Bot closed this Mar 10, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 10, 2026
…mmunity#35608)

This PR takes files relevant to Turing machines and moves them to a single folder for better organization.

In the process, we do some renaming of these files

* We remove the "TM" from the front of these files, as it's now redundant.
* TuringMachine.lean --> TuringMachine/StackTuringMachine.lean
  * (really the key difference between the TM2 model presented in this file, and the TM1 model from the previous, is the introduction of stacks instead of tapes)

I also remove `EvalsTo` and friends from TuringMachine.Computable, as these in leanprover-community#33291 were moved out of the TM namespace.

leanprover-community#35609 is a follow-up PR to add module deprecations.
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Mar 10, 2026
…mmunity#35608)

This PR takes files relevant to Turing machines and moves them to a single folder for better organization.

In the process, we do some renaming of these files

* We remove the "TM" from the front of these files, as it's now redundant.
* TuringMachine.lean --> TuringMachine/StackTuringMachine.lean
  * (really the key difference between the TM2 model presented in this file, and the TM1 model from the previous, is the introduction of stacks instead of tapes)

I also remove `EvalsTo` and friends from TuringMachine.Computable, as these in leanprover-community#33291 were moved out of the TM namespace.

leanprover-community#35609 is a follow-up PR to add module deprecations.
mathlib-bors Bot pushed a commit that referenced this pull request Mar 11, 2026
This follow-up deprecates files moved in #35608

This PR was made with the assistance of Claude Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

file-removed A Lean module was (re)moved without a `deprecated_module` annotation ready-to-merge This PR has been sent to bors. t-computability Computability theory (TMs, DFAs, languages, grammars, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants