perf: try letToHave for dependent lets in cbv#12856
Draft
wkrozowski wants to merge 1 commit intoleanprover:masterfrom
Draft
perf: try letToHave for dependent lets in cbv#12856wkrozowski wants to merge 1 commit intoleanprover:masterfrom
letToHave for dependent lets in cbv#12856wkrozowski wants to merge 1 commit intoleanprover:masterfrom
Conversation
This PR makes the `cbv` tactic try `letToHave` on dependent let bindings before falling back to zeta reduction. When the conversion succeeds, the resulting non-dependent let is beta-reduced directly, avoiding unnecessary zeta expansion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
!bench |
|
Benchmark results for b5a3c41 against e2b500b are in. There are no significant changes. @wkrozowski
Small changes (1✅, 1🟥)
|
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
cbvtactic tryletToHaveon dependent let bindingsbefore falling back to zeta reduction. When the conversion succeeds, the
resulting non-dependent let is beta-reduced directly, avoiding unnecessary
zeta expansion.