fix: handle lean4-nightly toolchain prefix in release checklist#12865
Merged
fix: handle lean4-nightly toolchain prefix in release checklist#12865
Conversation
This PR fixes a crash in release_checklist.py when a repository uses the leanprover/lean4-nightly: toolchain prefix (e.g. leansqlite). The is_version_gte function only checked for leanprover/lean4:nightly- but not leanprover/lean4-nightly:, causing a ValueError when trying to parse the version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in release_checklist.py when a repository uses the
leanprover/lean4-nightly:toolchain prefix (e.g. leansqlite). Theis_version_gtefunction only checked forleanprover/lean4:nightly-butnot
leanprover/lean4-nightly:, causing aValueError: invalid literal for int() with base 10: 'nightly'when trying to parse the version.🤖 Prepared with Claude Code