Admin Users: persist requested storage, rename and regroup filters, add clear action - #6096
Draft
akolson wants to merge 2 commits into
Draft
Admin Users: persist requested storage, rename and regroup filters, add clear action#6096akolson wants to merge 2 commits into
akolson wants to merge 2 commits into
Conversation
A storage request only ever sent an email, so the admin Users CSV "Storage needed" column could only show what a user typed at registration. Users who requested storage afterwards showed blank. Persist the requested amount to user.information and prefer it over the registration answer when building the CSV row. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
"Has Studio edits" matched any Change row the user ever created, so it reported activity rather than edits; renamed to "Has Studio activity" in the filter row and the CSV header. On wide viewports the two checkboxes sat in separate quarter-width columns, leaving a large gap between them. They now share one half-width flex row alongside a "Clear filters" action, which resets every filter while preserving pagination and sorting. The action is enabled only once a filter differs from the default its control already displays. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes QA follow-ups from #5946, all on the admin Users page.
information["space_needed"]is only written at registration, and only when the user ticks "Storing materials for private or local use" — the post-registration storage request flow just sent an email and persisted nothing. So users who requested storage after signing up showed blank, while older users who answered the registration question showed a value.StorageSettingsViewnow records the requested amount on the user, and the CSV prefers it over the registration answer. No migration:informationis an existingJSONField.Exists(Change.objects.filter(created_by=...)), which matches anyChangerow the user ever created — creating a channel qualifies, and deleting it later doesn't undo it. That is activity, not edits, which is what QA observed. Renamed in the filter row and the CSV header; the query param and backend annotation are unchanged, so existing bookmarked URLs still work.References
Fixes #5946
Reviewer guidance
Manually verified against a local devserver at 1600px and 820px, signed in as an admin: the renamed label, the two checkboxes now adjacent, "Clear filters" greyed out on a clean page, enabled after selecting "All", and the row wrapping cleanly at the narrow width. Screenshots to follow in a comment.
AI usage
Used Claude Code throughout, in a plan-then-review loop. I had it trace the root cause of the empty "Storage needed" column before proposing anything, and rejected its first design, which stored a
requested_ontimestamp nothing would read. I also caught that its clear-filters logic left the action disabled after selecting "All"; the fix was to compare each filter against the default its control already shows rather than against the params sent to the backend. Its first attempt at that comparison marked a clean page as filtered — the existing test suite caught it. I reviewed every diff, ran the frontend and backend suites and the linter, and verified the layout in a browser.