fix(controls): Fix NumberBox Value binding not updating ViewModel on lost focus #1607
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When NumberBox Value property is bound to a ViewModel, the ViewModel was not updated when focus was lost after text input. This was because SetCurrentValue() does not trigger binding source updates. Fixed by explicitly calling UpdateSource() in OnLostFocus() after ValidateInput() when the value has changed. Fixes issue where Text and Value properties updated correctly but ViewModel retained the previous value.
github-actions
bot
added
controls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
When binding to the Value of a NumberBox, there was a delay in value propagation after keyboard input.
Issue Number: #945
What is the new behavior?
When NumberBox Value property is bound to a ViewModel, the ViewModel
was not updated when focus was lost after text input. This was because
SetCurrentValue() does not trigger binding source updates.
Fixed by explicitly calling UpdateSource() in OnLostFocus() after
ValidateInput() when the value has changed.
Fixes issue where Text and Value properties updated correctly but
ViewModel retained the previous value.
Other information