Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a main entry point for the pywasm package to enable execution via python -m pywasm, consolidating functionality from separate scripts and adding comprehensive command-line interface features.
- Adds
__main__.pymodule with support for both WASI and regular WebAssembly function execution - Consolidates and removes standalone WASI execution scripts
- Updates type annotations to support bytearray arguments in the Runtime.invocate method
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pywasm/main.py | Main entry point with argument parsing for WASI and function execution modes |
| pywasm/core.py | Updates type annotations to include bytearray support in invocate method |
| test/main.py | Test script demonstrating the new main entry functionality |
| script/wasi_testsuite_adapter.py | Removed - functionality consolidated into main module |
| script/wasi.py | Removed - functionality consolidated into main module |
| README.md | Updates documentation to include new test command |
| .github/workflows/develop.yml | Adds new test to CI workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.