Autostart ircbot based on environment variable#317
Open
Olen wants to merge 2 commits intolibrenms:masterfrom
Open
Autostart ircbot based on environment variable#317Olen wants to merge 2 commits intolibrenms:masterfrom
Olen wants to merge 2 commits intolibrenms:masterfrom
Conversation
This will ensure that the irc-bot is started if irc_alert is configured.
crazy-max
requested changes
Oct 22, 2022
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Looking at this service I think we should have a new env var named smth like LIBRENMS_IRC_SERVICE instead of relying on irc_alert config.
- Changed startup to depend on nevironment variable - Fixed uid/gid - Shortened final sleep before restart (not sure about this one)
Olen
changed the title
Author
|
Seems like the bot is unable to send alerts. Possibly because the alerts are triggered by the dispatcher container, which does not have access to the .ircbot.alert file. |
Author
|
This PR needs to be merged to make alerting work in the container based environment. |
Member
Moving to draft while waiting for the upstream PR to be merged |
Member
|
Approved upstream, will be in 23.5 |
Author
|
Now that 23.5 has been released. This should be ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure that the irc-bot is started if the enviroment-variable LIBRENMS_IRC_SERVICE is set to "1".
You still need to enable irc_alert in the config to use the ircbot for alerting.