plugins: input-raw: Parse BTN_LEFT in MT mode#218
Open
dsemkowicz-tt wants to merge 1 commit intolibts:masterfrom
Open
plugins: input-raw: Parse BTN_LEFT in MT mode#218dsemkowicz-tt wants to merge 1 commit intolibts:masterfrom
dsemkowicz-tt wants to merge 1 commit intolibts:masterfrom
Conversation
Some devices, like eGalax USB HID touch panel, emulate a mouse device. In such case, BTN_LEFT instead of BTN_TOUCH event is read from evdev input. This case is already covered in `ts_input_read()`, but not in the `ts_input_read_mt()`. As `ts_uinput` tool always uses multitouch mode, such devices do not register touch events correctly. Handle BTN_LEFT in the same way as BTN_TOUCH is handled to fix this problem. This will now be common with `ts_input_read()` implementation. Signed-off-by: Daniel Semkowicz <dse@thaumatec.com>
Contributor
Author
|
Hello @merge, Are there any obstacles to merging this change into master? |
Member
|
I'm not sure about whether we can or should do this by default. as part of a hardware-quirk, it would be ok for sure |
Contributor
Author
|
If I understand the code correctly, the same behaviour is already implemented for single touch: https://github.com/libts/tslib/blob/master/plugins/input-raw.c#L373. Regarding a hardware-quirk approach, do you mean to implement the fix in the Linux kernel or tslib? |
Member
|
true, but ts_read() is really a different API I mean if you'd detect your device in (just as an idea), we could definitely merge that |
Contributor
Author
|
Ok, I will try to change implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some devices, like eGalax USB HID touch panel, emulate a mouse device. In such case, BTN_LEFT instead of BTN_TOUCH event is read from evdev input. This case is already covered in
ts_input_read(), but not in thets_input_read_mt(). Asts_uinputtool always uses multitouch mode, such devices do not register touch events correctly.Handle BTN_LEFT in the same way as BTN_TOUCH is handled to fix this problem. This will now be common with
ts_input_read()implementation.