Skip to content

fix: Report minor typo#19

Open
JiwaniZakir wants to merge 1 commit into
libyal:mainfrom
JiwaniZakir:fix/issue-18
Open

fix: Report minor typo#19
JiwaniZakir wants to merge 1 commit into
libyal:mainfrom
JiwaniZakir:fix/issue-18

Conversation

@JiwaniZakir
Copy link
Copy Markdown

Fixes #18

Corrects an incorrect byte offset in the named key v1.1 structure table within documentation/Windows NT Registry File (REGF) format.asciidoc. The "Last (key) written date and time" field was documented at offset 10, but the correct offset is 8, as the preceding fields (signature at offset 4, size 2; flags at offset 6, size 2) only span bytes 4-7. Updates the offset value from 10 to 8 in the AsciiDoc table. Verified by cross-checking the field layout against adjacent offsets (16 for Unknown, 20 for Parent key offset) which remain consistent with the corrected value.

@lottoian
Copy link
Copy Markdown

Thanks for the detailed fix.

This matches my understanding — offset 8 is correct based on the field layout.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.96%. Comparing base (572b615) to head (a3ff5f2).

❗ There is a different number of reports uploaded between BASE (572b615) and HEAD (a3ff5f2). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (572b615) HEAD (a3ff5f2)
4 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   29.69%   21.96%   -7.74%     
==========================================
  Files          38       38              
  Lines        8631     8561      -70     
  Branches     1996     1979      -17     
==========================================
- Hits         2563     1880     -683     
- Misses       5643     6373     +730     
+ Partials      425      308     -117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JiwaniZakir
Copy link
Copy Markdown
Author

Glad it matches your understanding @lottoian — thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report minor typo

2 participants