Draft
Conversation
- Implement ANDN, BEXTR, BLSI, BLSMSK, and BLSR with tests - Move TZCNT to be with the rest of the BMI instructions - Remove erroneous TZCNT r8 rm8 instruction
- Fixed BLSI CF flag - Fixed TZCNT duplicate on R32W/R32 to be R32W/M32
- Not a great solution, but I think the value is leaking over into the test cases - Should be fine, handlers are setup to catch unsupported instructions
This reverts commit 1262140.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs BMI2 support and the test cases to go with it