Update ldk-node dependency & expose bolt12 proofs - #258
Open
benthecarman wants to merge 3 commits into
Open
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
benthecarman
marked this pull request as ready for review
August 18, 2026 05:28
tnull
reviewed
Aug 18, 2026
wpaulino
removed their request for review
August 18, 2026 17:19
Adapt payment events to the updated ldk-node API and expose their payment IDs. Continue to handle unknown BOLT 11 payments manually so the receive-for-hash APIs work correctly. AI assistance: OpenAI Codex was used for this change.
Add payer-proof creation to the gRPC, CLI, and MCP interfaces. Include the preimage and invoice in successful-payment events because stateless proof creation requires both values. AI assistance: OpenAI Codex was used to rebase and verify this change.
benthecarman
force-pushed
the
update-ldk-node
branch
from
August 19, 2026 22:35
c41e3d8 to
a0b2517
Compare
Collaborator
Author
|
Rebased and updated ldk-node to new commit with the pagination changes. Now using the paginated payments instead of the ldk-server version |
tnull
reviewed
Aug 20, 2026
tnull
left a comment
tnull
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, but we should probably also include the new channel type in list_channels now.
Read payment pages directly from ldk-node so the server does not store duplicate payment records. Keep the server database for forwarded-payment history. AI assistance: OpenAI Codex was used for this change.
benthecarman
force-pushed
the
update-ldk-node
branch
from
August 20, 2026 16:44
a0b2517 to
1a3344b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update ldk-node and adapt payment events to its current API. Expose payment IDs in events and retain manual handling for unknown BOLT 11 payments.
Add BOLT 12 payer-proof creation to the gRPC, CLI, and MCP interfaces. Include the preimage and invoice in successful-payment events for stateless proof creation.
Use ldk-node pagination for payment history. Remove duplicate payment records from the ldk-server SQLite store, which now contains only forwarded-payment history.