-
Notifications
You must be signed in to change notification settings - Fork 427
Convert internal update handling fns to methods #4291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Convert internal update handling fns to methods #4291
Conversation
|
I've assigned @valentinewallace as a reviewer! |
dd25afd to
f687020
Compare
Pure code move except for the context logger which is now instantiated when needed in handle_monitor_update_internal.
f687020 to
dfbf531
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4291 +/- ##
=======================================
Coverage 89.38% 89.38%
=======================================
Files 180 180
Lines 139834 139836 +2
Branches 139834 139836 +2
=======================================
+ Hits 124985 124989 +4
+ Misses 12262 12259 -3
- Partials 2587 2588 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @valentinewallace! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @valentinewallace! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @valentinewallace! This PR has been waiting for your review. |
Small readability improvement