Skip to content

Conversation

@MishaKav
Copy link
Collaborator

@MishaKav MishaKav commented Nov 26, 2025

Summary

Use the slack-notification composite action from shared-workflows.

JIRA: https://linearb.atlassian.net/browse/LINBEE-20794

🤖 Generated with Claude Code

✨ PR Description

Purpose: Replace external Slack notification action with internal shared workflow to standardize notification format and consolidate implementation.
Main changes:

  • Replaced rtCamp/action-slack-notify with linear-b/shared-workflows/.github/actions/slack-notification
  • Consolidated success and failure notifications into a single conditional action
  • Simplified message format while preserving release information and links

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link
Contributor

@gitstream-cm gitstream-cm bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

The refactoring consolidates two separate notification steps into one shared action, which improves maintainability. However, there are concerns about using an unstable branch reference and handling of non-standard job statuses.

2 issues detected:

🧹 Maintainability - Using a branch reference instead of a stable version tag creates unpredictable behavior and potential breaking changes.

Details: The workflow references the shared action using '@develop' branch instead of a stable tag or version. This creates non-deterministic builds where changes to the develop branch could unexpectedly break this workflow without warning. It also makes it harder to track which version of the action is being used and violates GitHub Actions best practices.
File: .github/workflows/create-tag-on-merge.yml

🐞 Bug - Cancelled jobs will display 'Failed to release' which is technically inaccurate and could cause confusion. 🛠️

Details: The notification uses 'always()' condition which means it will run even when the job is cancelled. However, the message only distinguishes between 'success' and any other status, displaying 'Failed to release' for cancelled jobs. This differs from the previous behavior where no notification was sent on cancellation.
File: .github/workflows/create-tag-on-merge.yml (129-129)
🛠️ A suggested code correction is included in the review comments.

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how

webhook_url: ${{ env.SLACK_WEBHOOK }}
footer_links: <${{ github.server_url }}/${{ github.repository }}/releases/tag/${{ env.NEW_TAG }}|${{ env.NEW_TAG }}>
message: |
${{ job.status == 'success' && 'Released' || 'Failed to release' }} `${{ env.NEW_TAG }}` to `gitstream-github-action`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐞 Bug - Inaccurate Message: Add explicit handling for the 'cancelled' status in the message, or change the condition from 'always()' to '(success() || failure())' to match the previous behavior.

Suggested change
${{ job.status == 'success' && 'Released' || 'Failed to release' }} `${{ env.NEW_TAG }}` to `gitstream-github-action`
${{ job.status == 'success' && 'Released' || (job.status == 'cancelled' && 'Cancelled release of' || 'Failed to release') }} `${{ env.NEW_TAG }}` to `gitstream-github-action`
Is this review accurate? Use 👍 or 👎 to rate it

If you want to tell us more, use /gs feedback e.g. /gs feedback this review doesn't make sense, I disagree, and it keeps repeating over and over

@MishaKav MishaKav merged commit 7eea379 into develop Nov 26, 2025
15 checks passed
@MishaKav MishaKav deleted the LINBEE-20794-use-shared-slack-notification branch November 26, 2025 13:48
MishaKav added a commit that referenced this pull request Nov 27, 2025
MishaKav added a commit that referenced this pull request Nov 27, 2025
MishaKav added a commit that referenced this pull request Nov 27, 2025
* bump @linearb/gitstream-core to 2.1.227

* Revert "refactor: use shared slack-notification action (#437)"

This reverts commit 7eea379.

---------

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: Misha Kav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants