-
Notifications
You must be signed in to change notification settings - Fork 10
refactor: use shared slack-notification action [skip ci] #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ PR Review
The refactoring consolidates two separate notification steps into one shared action, which improves maintainability. However, there are concerns about using an unstable branch reference and handling of non-standard job statuses.
2 issues detected:
🧹 Maintainability - Using a branch reference instead of a stable version tag creates unpredictable behavior and potential breaking changes.
Details: The workflow references the shared action using '@develop' branch instead of a stable tag or version. This creates non-deterministic builds where changes to the develop branch could unexpectedly break this workflow without warning. It also makes it harder to track which version of the action is being used and violates GitHub Actions best practices.
File:.github/workflows/create-tag-on-merge.yml🐞 Bug - Cancelled jobs will display 'Failed to release' which is technically inaccurate and could cause confusion. 🛠️
Details: The notification uses 'always()' condition which means it will run even when the job is cancelled. However, the message only distinguishes between 'success' and any other status, displaying 'Failed to release' for cancelled jobs. This differs from the previous behavior where no notification was sent on cancellation.
File:.github/workflows/create-tag-on-merge.yml (129-129)
🛠️ A suggested code correction is included in the review comments.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how
| webhook_url: ${{ env.SLACK_WEBHOOK }} | ||
| footer_links: <${{ github.server_url }}/${{ github.repository }}/releases/tag/${{ env.NEW_TAG }}|${{ env.NEW_TAG }}> | ||
| message: | | ||
| ${{ job.status == 'success' && 'Released' || 'Failed to release' }} `${{ env.NEW_TAG }}` to `gitstream-github-action` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐞 Bug - Inaccurate Message: Add explicit handling for the 'cancelled' status in the message, or change the condition from 'always()' to '(success() || failure())' to match the previous behavior.
| ${{ job.status == 'success' && 'Released' || 'Failed to release' }} `${{ env.NEW_TAG }}` to `gitstream-github-action` | |
| ${{ job.status == 'success' && 'Released' || (job.status == 'cancelled' && 'Cancelled release of' || 'Failed to release') }} `${{ env.NEW_TAG }}` to `gitstream-github-action` |
Is this review accurate? Use 👍 or 👎 to rate it
If you want to tell us more, use /gs feedback e.g. /gs feedback this review doesn't make sense, I disagree, and it keeps repeating over and over
* bump @linearb/gitstream-core to 2.1.227 * Revert "refactor: use shared slack-notification action (#437)" This reverts commit 7eea379. --------- Co-authored-by: GitHub Actions Bot <[email protected]> Co-authored-by: Misha Kav <[email protected]>
Summary
Use the
slack-notificationcomposite action from shared-workflows.JIRA: https://linearb.atlassian.net/browse/LINBEE-20794
🤖 Generated with Claude Code
✨ PR Description
Purpose: Replace external Slack notification action with internal shared workflow to standardize notification format and consolidate implementation.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how