Skip to content

Conversation

@ceolinwill
Copy link
Contributor

@ceolinwill ceolinwill commented Dec 13, 2025

Summary

@vrcprl #1662 didn't fully fix #1661 because there's a race condition in _utils.ts where pullInput and pullOutput are stored as single values that get overwritten on each pull() call

Changes

  • Changed state storage from single values to per-locale using Map

Testing

Business logic tests added:

  • Check the Language header is correct on concurrent processing
  • All tests pass locally

I also made sure to test locally with npm link this time. Sorry I didn't do it last time.

Visuals

Required for UI/UX changes:

  • Before/after screenshots attached
  • Video demo for interactions (< 30s)

Checklist

  • Changeset added (if version bump needed)
  • Tests cover business logic (not just happy path)
  • No breaking changes (or documented below)

Closes #1661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI replaces Language value with source language in PO files

1 participant