feat: add aclp alert channel API support by shkaruna · Pull Request #997 · linode/linodego

shkaruna · 2026-06-23T08:51:16Z

📝 Description

This PR adds support for ACLP alert notification channels.
POST /monitor/alert-channels
GET /monitor/alert-channels/{id}
PUT /monitor/alert-channels/{id}
DELETE /monitor/alert-channels/{id}
GET /monitor/alert-channels/{id}/alerts

✔️ How to Test

Unit Tests

Run all the unit tests:
make test-unit
Run Monitor alert definition unit tests:
go test -v ./test/unit/... -run AlertChannel

Integration Tests

Play mode:
Run all integration tests (sets LINODE_FIXTURE_MODE="play"):
make test-int

Run alert channel integration tests:
make test-int TEST_ARGS='-run "AlertChannel"'

Record mode:
export LINODE_TOKEN=<my_token>
ENABLE_CLOUD_FW=false make TEST_ARGS='-run "TestMonitorAlertChannel_CRUD_E2E"' fixtures
ENABLE_CLOUD_FW=false make TEST_ARGS='-run "TestMonitorAlertChannel_ListAlerts"' fixtures

…clp-alert-channels

…a/linodego into feat/aclp-alert-channels

Copilot

Pull request overview

Adds Linodego client support for ACLP Monitor alert notification channels, including CRUD operations and listing alert definitions attached to a channel, plus accompanying unit/integration test coverage and recorded fixtures.

Changes:

Introduces AlertChannelCreateOptions / AlertChannelUpdateOptions and client methods: GetAlertChannel, CreateAlertChannel, UpdateAlertChannel, DeleteAlertChannel, and ListAlertsForChannel.
Expands unit tests for alert channels to cover CRUD + list-alerts behavior with updated mock responses.
Updates integration tests/fixtures to create and clean up alert channels during monitor alert definition flows, and adds new E2E fixtures for alert-channel CRUD and list-alerts.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
monitor_alert_channels.go	Adds alert-channel CRUD + list-alerts client methods and request/response types.
test/unit/monitor_alert_channels_test.go	Adds unit tests for alert channel CRUD and listing alerts; updates mock payloads.
test/integration/monitor_alerts_test.go	Updates integration tests to create/delete alert channels during alert-definition tests; adds alert-channel E2E tests.
test/integration/fixtures/TestMonitorAlertDefinition.yaml	Records additional interactions for user lookup + alert-channel creation/deletion during smoke flow.
test/integration/fixtures/TestMonitorAlertDefinition_CreateWithIdempotency.yaml	Updates fixture to record user lookup + alert-channel creation/deletion.
test/integration/fixtures/TestMonitorAlertDefinition_Clone.yaml	Updates fixture to record user lookup + alert-channel creation/deletion for clone flow.
test/integration/fixtures/TestMonitorAlertChannel_ListAlerts.yaml	New fixture for alert-channel list-alerts integration test.
test/integration/fixtures/TestMonitorAlertChannel_CRUD.yaml	New fixture for alert-channel CRUD integration test.

Comments suppressed due to low confidence (7)

test/integration/monitor_alerts_test.go:110

channelID is still declared in the package-level const block, but it is no longer referenced anywhere in the integration test package after switching to creating channels dynamically. This will make the test/integration package fail to compile due to an unused identifier; please remove the stale constant (and its TODO) or reintroduce a usage.
test/integration/monitor_alerts_test.go:110
This test indexes users[1] later when building Usernames, but it only checks the error from ListUsers. If the account has fewer than 2 users (common in record mode), this will panic. Add an explicit length assertion before indexing.

This issue also appears in the following locations of the same file:

line 289
line 412
line 533
line 620
test/integration/monitor_alerts_test.go:290

This test indexes users[1] later when building Usernames, but it only checks the error from ListUsers. If the account has fewer than 2 users (common in record mode), this will panic. Add an explicit length assertion before indexing.
test/integration/monitor_alerts_test.go:413
This test indexes users[1] later when building Usernames, but it only checks the error from ListUsers. If the account has fewer than 2 users (common in record mode), this will panic. Add an explicit length assertion before indexing.
test/integration/monitor_alerts_test.go:534
This test indexes users[1] when building Usernames, but it only checks the error from ListUsers. If the account has fewer than 2 users, this will panic. Add an explicit length assertion before indexing.
test/integration/monitor_alerts_test.go:621
This test indexes users[1] when building Usernames, but it only checks the error from ListUsers. If the account has fewer than 2 users, this will panic. Add an explicit length assertion before indexing.
test/unit/monitor_alert_channels_test.go:85
The API/fixtures use "type": "alerts-definitions" in the alerts block (see this file's list response and integration fixtures), but the update response uses "alert-definitions" (missing the 's'). This inconsistency makes the unit fixture less representative and can hide issues.

		"alerts": {
			"alert_count": 0,
			"type": "alert-definitions",
			"url": "/monitor/alert-channels/10000/alerts"
		}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 		"alerts": {
-			"url": "/monitor/alert-channels/123/alerts",
-			"type": "alerts-definitions",
-			"alert_count": 0
-		},
-		"created": "2024-01-01T00:00:00",
-		"updated": "2024-01-01T00:00:00",
+			"alert_count": 0,
+			"type": "alert-definitions",
+			"url": "/monitor/alert-channels/10000/alerts"
+		}


+// EmailChannelUpdateOptions represents email-specific update configuration for an alert channel.
+type EmailChannelUpdateOptions struct {
+	Usernames []string `json:"usernames,omitzero"`
+}


+// Alert represents an alert definition assigned to a notification channel.
+type Alert struct {
+	ID          int    `json:"id"`
+	Label       string `json:"label"`
+	ServiceType string `json:"service_type"`
+	Type        string `json:"type"`
+	URL         string `json:"url"`
+}


psnoch-akamai · 2026-08-05T12:18:33Z

+	if err != nil {
+		t.Fatalf("failed to create alert channel: %v", err)
 	}


Suggested change

if err != nil {

t.Fatalf("failed to create alert channel: %v", err)

}

require.NoError(t, err, "failed to create alert channel: %v", err)

psnoch-akamai · 2026-08-05T12:20:40Z

+		},
+	}
+
+	ch, err := client.CreateAlertChannel(context.Background(), createChannelOpts)


How about renaming "ch" to more descriptive name, like "alertChannel"?

psnoch-akamai · 2026-08-05T12:21:59Z

-	assert.NotEmpty(t, fetchedChannelLabel, "fetchedChannel.Label should not be empty")
+	defer deleteAlertChannelWithRetry(t, client, ch.ID)
+
+	channelID := ch.ID


I would remove this variable as it's used only once

psnoch-akamai · 2026-08-05T12:24:41Z

+		Label:       fmt.Sprintf("linodego-alert-%d", time.Now().UnixNano()),
 		Severity:    int(linodego.SeverityLow),
 		Description: linodego.Pointer("Test alert definition creation"),
 		ChannelIDs:  []int{channelID},


Suggested change

ChannelIDs: []int{channelID},

ChannelIDs: []int{ch.ID},

psnoch-akamai · 2026-08-05T12:30:45Z

+	if err != nil {
+		t.Fatalf("failed to create alert channel: %v", err)
+	}


Suggested change

if err != nil {

t.Fatalf("failed to create alert channel: %v", err)

}

require.NoErrorf(t, err, "failed to create alert channel: %v", err)

psnoch-akamai · 2026-08-05T12:31:50Z

+	require.NotNil(t, createdAlert)
+	// ensure cleanup of created alert definition
+	defer func() {
+		if createdAlert != nil {


This conditional is not needed as you check the same as line 363

psnoch-akamai · 2026-08-05T12:36:49Z

+
+	// Delete the created alert channel after the test completes
+	defer func() {
+		if channel != nil {


Suggested change

if channel != nil {

It's not needed as it's already checked at above

psnoch-akamai · 2026-08-05T12:40:35Z

+
+	// ensure cleanup
+	var createdAlert *linodego.AlertDefinition
+	defer func() {


How about put it just after create step?

shkaruna added 5 commits June 23, 2026 14:01

feat: add aclp alert channel API support

be44f61

feat: add aclp alert channel support

4690ce3

feat: add aclp alert channel support

d37b1cb

Merge branch 'main' of https://github.com/linode/linodego into feat/a…

b1b7238

…clp-alert-channels

ref: updated aclp integration tests

756f666

mawasthy-lgtm reviewed Jul 17, 2026

View reviewed changes

Comment thread test/integration/monitor_alerts_test.go Outdated

shkaruna added 2 commits July 21, 2026 16:42

ref: updated aclp integration tests

f1cdcf4

Merge branch 'feat/aclp-alert-channels' of https://github.com/shkarun…

58abb7b

…a/linodego into feat/aclp-alert-channels

shkaruna marked this pull request as ready for review July 28, 2026 04:41

shkaruna requested review from a team as code owners July 28, 2026 04:41

shkaruna requested review from Copilot, ezilber-akamai and mawilk90 and removed request for a team July 28, 2026 04:41

Copilot started reviewing on behalf of shkaruna July 28, 2026 04:41 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

mawilk90 requested review from psnoch-akamai and yec-akamai July 28, 2026 06:31

psnoch-akamai reviewed Aug 5, 2026

View reviewed changes

Navigation Menu

Uh oh!

feat: add aclp alert channel API support - #997

feat: add aclp alert channel API support#997
shkaruna wants to merge 7 commits into
linode:mainfrom
shkaruna:feat/aclp-alert-channels

shkaruna commented Jun 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

psnoch-akamai Aug 5, 2026

Uh oh!

psnoch-akamai Aug 5, 2026

Uh oh!

psnoch-akamai Aug 5, 2026

Uh oh!

psnoch-akamai Aug 5, 2026

Uh oh!

psnoch-akamai Aug 5, 2026

Uh oh!

psnoch-akamai Aug 5, 2026

Uh oh!

psnoch-akamai Aug 5, 2026

Uh oh!

psnoch-akamai Aug 5, 2026

Uh oh!

psnoch-akamai Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

shkaruna commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

✔️ How to Test

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shkaruna commented Jun 23, 2026 •

edited

Loading