ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows and documentation to use tox-lsr 3.16.0 and the new qemu/container ansible-core environment naming scheme.

CI:

• Bump tox-lsr version from 3.15.0 to 3.16.0 across GitHub Actions workflows.
• Adjust qemu and container ansible-core matrix environment names in qemu-kvm integration tests to use dash-separated major-minor versions instead of dotted versions.

Documentation:

• Update contributing guide example to use the new dash-separated qemu ansible-core tox environment name.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox usage to tox-lsr 3.16.0 and renames qemu/container tox environments from dot-separated to dash-separated ansible-core version identifiers to avoid tox 4.49 misinterpreting them as Python versions.

Flow diagram for running qemu tox env with dash-separated ansible-core version

graph TD
  Dev[Developer] --> C1[Choose ansible-core version X_Y]
  C1 --> C2[Construct env name qemu-ansible-core-X-Y]
  C2 --> R1[Run command: tox -e qemu-ansible-core-2-20 -- --image-name centos-9 tests/tests_default.yml]
  R1 --> Tox[tox]
  Tox --> Env[qemu-ansible-core-2-20 env]
  Env --> QEMU[Start QEMU image centos-9]
  QEMU --> Tests[Execute tests_default.yml]

Loading

File-Level Changes

Change	Details	Files
Rename qemu and container tox environment identifiers from dot to dash notation to avoid tox 4.49 interpreting them as Python versions.	Update qemu ansible-core matrix env names from qemu-ansible-core-2.X to qemu-ansible-core-2-X in the qemu-kvm integration workflow. Update container ansible-core matrix env names from container-ansible-core-2.X to container-ansible-core-2-X in the qemu-kvm integration workflow. Adjust the example tox invocation in contributing documentation to use the new qemu-ansible-core-2-20 environment name.	.github/workflows/qemu-kvm-integration-tests.yml contributing.md
Bump tox-lsr version used in CI workflows from 3.15.0 to 3.16.0.	Update tox-lsr version in qemu-kvm integration tests workflow. Update tox-lsr version in ansible-lint workflow. Update tox-lsr version in ansible-managed-var-comment workflow. Update tox-lsr version in ansible-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The example in contributing.md was changed from qemu-ansible-core-2.14 to qemu-ansible-core-2-20, which goes beyond just the dot-to-dash rename described in the PR; consider keeping the same Ansible core version and only changing . to - to avoid confusing readers about supported versions.
• The tox-lsr version 3.16.0 is hardcoded in multiple workflow files; consider defining it once (e.g., as a workflow env or reusable workflow input) to avoid divergence the next time it needs to be updated.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The example in contributing.md was changed from `qemu-ansible-core-2.14` to `qemu-ansible-core-2-20`, which goes beyond just the dot-to-dash rename described in the PR; consider keeping the same Ansible core version and only changing `.` to `-` to avoid confusing readers about supported versions.
- The tox-lsr version `3.16.0` is hardcoded in multiple workflow files; consider defining it once (e.g., as a workflow env or reusable workflow input) to avoid divergence the next time it needs to be updated.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}