json2logs: fix warn status treated as failure and sanitize FQN filename - #106
Closed
AshWizard wants to merge 1 commit into
Closed
json2logs: fix warn status treated as failure and sanitize FQN filename#106AshWizard wants to merge 1 commit into
AshWizard wants to merge 1 commit into
Conversation
The condition `status not in ("pass", "conf")` treated warn tests as
failures, writing them to fails.log and generating .fail.log files.
Changed to `status in ("fail", "brok")` so only actual failures and
broken tests are reported.
Also replace "/" in test FQN before using it as a filename to avoid
creating unintended subdirectories.
Signed-off-by: Michael Menasherov <mmenashe@redhat.com>
Member
|
This tooling merely follows exactly same logic the old ltp-pan had. I.e. any process that exists with non-zero either goes into Since this is compatibility layer that is supposed to exactly mimic the old Also warnings in LTP are usually produced for serious enough errors, e.g. cleanup failed to restore the system, and tests that produce warnings shouldn't be considered as passed. Hiding them is not a good idea overall. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition
status not in ("pass", "conf")treated warn tests asfailures, writing them to fails.log and generating .fail.log files.
Changed to
status in ("fail", "brok")so only actual failures andbroken tests are reported.
Also replace "/" in test FQN before using it as a filename to avoid
creating unintended subdirectories.
Signed-off-by: Michael Menasherov mmenashe@redhat.com