-
Notifications
You must be signed in to change notification settings - Fork 60
fix(notification): improve text rendering at high DPI scaling #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideSets all text elements in the notification item content to use Qt-based text rendering to fix faint font strokes at high DPI scaling, and cleans up a minor layout expression whitespace issue. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Since
renderType: Text.QtRenderingis now required for consistent notification text rendering, consider moving this into a shared text style or base component used by notifications so it’s applied uniformly and future additions don’t have to remember to set it manually.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `renderType: Text.QtRendering` is now required for consistent notification text rendering, consider moving this into a shared text style or base component used by notifications so it’s applied uniformly and future additions don’t have to remember to set it manually.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Set renderType to Text.QtRendering for all Text elements in notification content to fix faint font strokes at 4K 150% scaling. 修复通知中心在高DPI缩放下的字体渲染问题,为所有文本元素设置Qt渲染模式。 Log: 修复高DPI缩放下字体渲染问题 PMS: BUG-345405 Influence: 在4K 150%缩放下,通知文字的笔画(如"开"字的竖笔)现在显示清晰,与控制中心等其他控件的渲染效果保持一致。
deepin pr auto review这段代码修改涉及到了QML中Text元素的渲染方式设置以及一些格式调整。以下是对该diff的详细审查意见: 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
改进建议:
renderType: Qt.styleHints.useRtlExtensions ? Text.QtRendering : Text.NativeRendering这样可以根据平台特性选择更合适的渲染方式。
// 使用Qt渲染引擎以确保跨平台文本一致性
renderType: Text.QtRendering
总体来说,这个修改主要是为了统一文本渲染方式,提高跨平台一致性,但需要注意性能和渲染质量的权衡。建议在实际使用中进行充分测试。 |
|
/merge |
|
This pr cannot be merged! (status: unstable) |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
Set renderType to Text.QtRendering for all Text elements in notification content to fix faint font strokes at 4K 150% scaling.
修复通知中心在高DPI缩放下的字体渲染问题,为所有文本元素设置Qt渲染模式。
Log: 修复高DPI缩放下字体渲染问题
PMS: BUG-345405
Influence: 在4K 150%缩放下,通知文字的笔画(如"开"字的竖笔)现在显示清晰,与控制中心等其他控件的渲染效果保持一致。
Summary by Sourcery
Bug Fixes: