fix: member attributes should have non empty values and a filled default by themarolt · Pull Request #3449 · linuxfoundation/crowd.dev

themarolt · 2025-10-04T17:17:40Z

Changes proposed ✍️

What

copilot:summary

copilot:poem

Why

How

copilot:walkthrough

Checklist ✅

Label appropriately with Feature, Improvement, or Bug.
Add screenshots to the PR description for relevant FE changes
New backend functionality has been unit-tested.
API documentation has been updated (if necessary) (see docs on API documentation).
Quality standards are met.

Note

Medium Risk
Introduces a new batch script that updates persisted member attributes in-place and changes default-value derivation/deletion logic, so mistakes could affect many member records. Type/signature tweaks are low risk but could surface runtime issues if any call sites weren’t updated consistently.

Overview
Fixes how member attribute default values are derived by only considering non-empty platform-specific values and by preserving existing non-empty default values instead of deleting the attribute when no platform source exists.

Adds a fix-member-attributes worker script to backfill members whose attribute objects have empty default values despite having non-empty platform values; it batches through affected members, recomputes defaults via MemberAttributeService, and preserves manually-changed attributes based on manuallyChangedFields before writing updates.

Cleans up member creation/update call paths to use PlatformType consistently (incl. MemberAttributeService.validateAttributes parameter order and ActivityService member creation metadata typing).

^{Written by Cursor Bugbot for commit 8775bd9. This will update automatically on new commits. Configure here.}

joanagmaia · 2026-01-13T10:47:36Z

Hey @themarolt @skwowet. Shouldn't this be merged? If it was done 3 months ago, maybe the work has already been overridden? Or is this not needed anymore?

skwowet · 2026-01-14T10:52:19Z

@joanagmaia this should be merged, if I’m not mistaken.

I think it came from one of the support tickets (trying to remember which one..)

joanagmaia · 2026-03-23T17:00:32Z

@themarolt pinging once again on this one, should this be merged or closed?

themarolt · 2026-03-23T18:22:09Z

@themarolt pinging once again on this one, should this be merged or closed?

Oh damn - I totally forgot about this one - let me merge main and check if this is still relevant.

github-actions · 2026-03-23T20:46:56Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

github-actions · 2026-03-23T20:47:13Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

Copilot

Pull request overview

This PR aims to ensure member attribute “default” values are derived from a non-empty platform value (based on platform priority), and adjusts the data sink worker to pass PlatformType through the member/attribute validation pipeline. It also adds a one-off script to backfill/fix existing members with missing attribute defaults.

Changes:

Update shared setAttributesDefaultValues logic to ignore empty/blank platform values when choosing the default.
Reorder/propagate PlatformType through MemberAttributeService.validateAttributes and MemberService create/update flows.
Add a fix-member-attributes.ts script to patch existing DB records with empty default attribute values.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
services/libs/common/src/member.ts	Filters attribute platforms to non-empty values before selecting the default.
services/apps/data_sink_worker/src/service/memberAttribute.service.ts	Reorders `validateAttributes` params to accept `platform` first.
services/apps/data_sink_worker/src/service/member.service.ts	Changes create/update signatures and call sites to use `PlatformType` (instead of `source: string`).
services/apps/data_sink_worker/src/service/activity.service.ts	Updates member creation call to satisfy new `PlatformType` signature (currently via cast).
services/apps/data_sink_worker/src/bin/fix-member-attributes.ts	New batch script to find and fix members with empty attribute defaults.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

services/libs/common/src/member.ts

services/apps/data_sink_worker/src/service/activity.service.ts

services/apps/data_sink_worker/src/bin/fix-member-attributes.ts

github-actions · 2026-03-23T21:02:48Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

github-actions · 2026-03-23T21:05:30Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

…utes Signed-off-by: Uroš Marolt <uros@marolt.me>

Signed-off-by: Uroš Marolt <uros@marolt.me>

github-actions · 2026-03-23T21:13:55Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

services/libs/common/src/member.ts

services/apps/data_sink_worker/src/bin/fix-member-attributes.ts

Signed-off-by: Uroš Marolt <uros@marolt.me>

github-actions · 2026-03-24T13:53:55Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

github-actions · 2026-03-24T13:57:57Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

services/apps/data_sink_worker/src/bin/fix-member-attributes.ts

Signed-off-by: Uroš Marolt <uros@marolt.me>

github-actions · 2026-03-24T14:09:15Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

services/libs/common/src/member.ts

Signed-off-by: Uroš Marolt <uros@marolt.me>

github-actions · 2026-03-24T14:29:21Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

github-actions · 2026-03-24T14:54:35Z

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

feat: add user authentication (CM-123)
feat: add user authentication (IN-123)

Projects:

CM: Community Data Platform
IN: Insights

Please add a Jira issue key to your PR title.

…ult (#3449) Signed-off-by: Uroš Marolt <uros@marolt.me> Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>

themarolt requested a review from skwowet October 4, 2025 17:22

skwowet previously approved these changes Oct 8, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings March 23, 2026 20:46

themarolt dismissed skwowet’s stale review via 6f25530 March 23, 2026 20:46

Copilot started reviewing on behalf of themarolt March 23, 2026 20:47 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

services/libs/common/src/member.ts Outdated Show resolved Hide resolved

services/apps/data_sink_worker/src/service/activity.service.ts Outdated Show resolved Hide resolved

cursor bot reviewed Mar 23, 2026

View reviewed changes

services/apps/data_sink_worker/src/bin/fix-member-attributes.ts Outdated Show resolved Hide resolved

themarolt added 15 commits March 23, 2026 22:13

fix: use platform instead of default for incorrectly formatted attrib…

3f76e55

…utes Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: script to fix the corrupted attributes

df455de

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

62eb163

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

d343400

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

174826b

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

10cd7f2

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

01b07a5

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

cd2e527

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

31bfc8a

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

2ad563f

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

fd4f319

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

b7d09d8

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

eb16c58

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

c080a4d

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

6033af5

Signed-off-by: Uroš Marolt <uros@marolt.me>

themarolt added 8 commits March 23, 2026 22:13

chore: fixed small issues

d99c730

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

6e6f8c7

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

8068e9b

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

7989f15

Signed-off-by: Uroš Marolt <uros@marolt.me>

chore: fixed small issues

8c802ba

Signed-off-by: Uroš Marolt <uros@marolt.me>

fix: lint

f1b502c

Signed-off-by: Uroš Marolt <uros@marolt.me>

fix: include manuallyChangedFields

bd5d1ca

Signed-off-by: Uroš Marolt <uros@marolt.me>

fix: comments

b444f81

Signed-off-by: Uroš Marolt <uros@marolt.me>

themarolt force-pushed the member-attribute-fix-CM-705 branch from c65b63c to b444f81 Compare March 23, 2026 21:13

cursor bot reviewed Mar 23, 2026

View reviewed changes

services/libs/common/src/member.ts Show resolved Hide resolved

services/apps/data_sink_worker/src/bin/fix-member-attributes.ts Show resolved Hide resolved

fix: ignore default platform

6a1d5ec

Signed-off-by: Uroš Marolt <uros@marolt.me>

Merge branch 'main' into member-attribute-fix-CM-705

b2520da

cursor bot reviewed Mar 24, 2026

View reviewed changes

services/apps/data_sink_worker/src/bin/fix-member-attributes.ts Outdated Show resolved Hide resolved

services/apps/data_sink_worker/src/bin/fix-member-attributes.ts Show resolved Hide resolved

fix: bugfix

faeeceb

Signed-off-by: Uroš Marolt <uros@marolt.me>

cursor bot reviewed Mar 24, 2026

View reviewed changes

services/libs/common/src/member.ts Show resolved Hide resolved

fix: bugfix

808425f

Signed-off-by: Uroš Marolt <uros@marolt.me>

Merge branch 'main' into member-attribute-fix-CM-705

8775bd9

themarolt merged commit 2352f05 into main Mar 24, 2026
14 checks passed

themarolt deleted the member-attribute-fix-CM-705 branch March 24, 2026 15:37

skwowet pushed a commit that referenced this pull request Mar 25, 2026

fix: member attributes should have non empty values and a filled defa…

720d119

…ult (#3449) Signed-off-by: Uroš Marolt <uros@marolt.me> Signed-off-by: Yeganathan S <63534555+skwowet@users.noreply.github.com>

Conversation

themarolt commented Oct 4, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed ✍️

What

Why

How

Checklist ✅

Uh oh!

joanagmaia commented Jan 13, 2026

Uh oh!

skwowet commented Jan 14, 2026

Uh oh!

joanagmaia commented Mar 23, 2026

Uh oh!

themarolt commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

themarolt commented Oct 4, 2025 •

edited by cursor bot

Loading