Include vendored nanoarrow source in Hex package#159
Merged
josevalim merged 1 commit intolivebook-dev:mainfrom Apr 24, 2026
Merged
Include vendored nanoarrow source in Hex package#159josevalim merged 1 commit intolivebook-dev:mainfrom
nanoarrow source in Hex package#159josevalim merged 1 commit intolivebook-dev:mainfrom
Conversation
trevenrawr
commented
Apr 23, 2026
| name: "adbc", | ||
| files: | ||
| ~w(3rd_party/apache-arrow-adbc c_src lib mix.exs README* LICENSE* CMakeLists.txt Makefile Makefile.win checksum.exs), | ||
| ~w(3rd_party/apache-arrow-adbc 3rd_party/nanoarrow c_src lib mix.exs README* LICENSE* CMakeLists.txt Makefile Makefile.win checksum.exs), |
Contributor
Author
There was a problem hiding this comment.
Another option, perhaps:
Suggested change
| ~w(3rd_party/apache-arrow-adbc 3rd_party/nanoarrow c_src lib mix.exs README* LICENSE* CMakeLists.txt Makefile Makefile.win checksum.exs), | |
| ~w(3rd_party c_src lib mix.exs README* LICENSE* CMakeLists.txt Makefile Makefile.win checksum.exs), |
Contributor
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howdy, ADBC folks!
I have a bit of a special setup where I'm running on Alpine and need to build ADBC from source. I just upgraded to 0.11.0 and my build threw an error because the
nanoarrowsource doesn't seem to be included in the Hex package like the source forapache_arrow_adbcis: https://github.com/livebook-dev/adbc/blob/main/mix.exs#L114I'm working around the issue with a
gitcheckout and copying the vendored source over to mydeps/adbcdir during my image build, but figured I should propose this change here in casenanoarrowis around to stay.Thanks for all the awesome work!