Repository navigation
Release room on server-ended disconnect - #95
Merged
Merged
Conversation
The server-ended disconnect path never cleared the UI's shared room handle, keeping the whole engine and published tracks alive until the next connect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ladvoc
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a server-ended disconnect (room deleted, participant removed), the service took
running_statebut never clearedinner.room, theArc<Room>shared with the UI. The client-ended path already clears it. As a result, the old room's engine, peer connections and published tracks stayed alive until the next connect replaced the handle.Found while trying to reproduce livekit/rust-sdks#1443 with a local
livekit-server --dev, publishing the sine track and runninglk room deleteon the server.@ladvoc Claude decided to use your prefix for the branch... 🤷