Skip to content

Conversation

@longcw
Copy link
Contributor

@longcw longcw commented Jan 23, 2026

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 23, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking about this, I'm not sure that we need diffs initially.

using sqlite seems like a good idea, but the need for diffs seems small.

  • the same session should be sticky to the same instance as long as that worker is still registered for this session
  • if the worker removed the session, all existing storage would be removed too. so it'd have to send the whole thing next time.

@longcw
Copy link
Contributor Author

longcw commented Jan 26, 2026

@davidzhao diff is used to compute the changeset to upload to the cloud.

@davidzhao
Copy link
Member

@davidzhao diff is used to compute the changeset to upload to the cloud.

ah of course. 🤦🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants