-
Notifications
You must be signed in to change notification settings - Fork 2.7k
export session state as db and compute delta for sync #4604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: longc/text-mode
Are you sure you want to change the base?
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
davidzhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking about this, I'm not sure that we need diffs initially.
using sqlite seems like a good idea, but the need for diffs seems small.
- the same session should be sticky to the same instance as long as that worker is still registered for this session
- if the worker removed the session, all existing storage would be removed too. so it'd have to send the whole thing next time.
|
@davidzhao diff is used to compute the changeset to upload to the cloud. |
ah of course. 🤦🏻♂️ |
No description provided.