fix(voice): avoid old-agent reply generation when handoff is required#5184
Open
api2062 wants to merge 1 commit intolivekit:mainfrom
Open
fix(voice): avoid old-agent reply generation when handoff is required#5184api2062 wants to merge 1 commit intolivekit:mainfrom
api2062 wants to merge 1 commit intolivekit:mainfrom
Conversation
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
onurburak9
reviewed
Mar 23, 2026
Contributor
onurburak9
left a comment
onurburak9
left a comment
There was a problem hiding this comment.
Thanks for improving the handoff flow, lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When both handoff and reply are required in the same turn, the old agent can still produce an extra reply before control moves to the new agent.
This change ensures handoff takes priority and prevents extra old-agent reply generation.
It also preserves previously discovered handoff tasks by avoiding replacement with None.
Changes
not handoff requiredin pipeline and realtime pathsnew_agent_taskwhen a non-None task is providedValidation
uv run pytest tests/test_agent_session.py -q(18 passed)Closes #5150