Skip to content

feat: enable AGC by default on RoomInput audio#5185

Merged
theomonnom merged 1 commit intomainfrom
theo/agc-room-input
Mar 23, 2026
Merged

feat: enable AGC by default on RoomInput audio#5185
theomonnom merged 1 commit intomainfrom
theo/agc-room-input

Conversation

@theomonnom
Copy link
Member

No description provided.

@chenghao-mou chenghao-mou requested a review from a team March 20, 2026 23:17
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 3 additional findings in Devin Review.

Open in Devin Review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 AGC not applied to pre-connect audio buffer frames

The new _process_frame hook (which applies AGC via AudioProcessingModule) is called for regular stream frames in the base _forward_task at _input.py:153, but the pre-connect audio path in _ParticipantAudioInputStream._forward_task at _input.py:320 sends frames through _apply_audio_processor (noise cancellation) and _resample_frames without calling _process_frame. This means the initial pre-connect audio buffer will not have automatic gain control applied, while all subsequent stream frames will. This creates an inconsistent audio gain level at the transition from pre-connect to live audio.

(Refers to lines 320-322)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@theomonnom theomonnom merged commit 50658a0 into main Mar 23, 2026
16 of 23 checks passed
@theomonnom theomonnom deleted the theo/agc-room-input branch March 23, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants