Skip to content

Fix RTC reconnection and WebSocket connection notification issue #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CMzhizhe wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix RTC reconnection and WebSocket connection notification issue #885

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
436f7e9
bugfix: After fixing the failure of RTC reconnection and WebSocket co…
CMzhizhe Mar 16, 2026
27e0214
bugfix: Remove unnecessary code
CMzhizhe Mar 24, 2026
d7848c6
bugfix: Remove unnecessary code
CMzhizhe Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions livekit-android-sdk/src/main/java/io/livekit/android/room/SignalClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,9 @@ constructor(
LKLog.e(e) { "failed to validate connection" }
}

val wasConnected = isConnected
val wasConnecting = joinContinuation != null

if (reason != null) {
LKLog.e(t) { "websocket failure: $reason" }
val error = Exception(reason)
Expand All @@ -361,11 +364,11 @@ constructor(
}
joinContinuation = null

val wasConnected = isConnected

if (wasConnected) {
if (wasConnected || wasConnecting) {
// onClosing/onClosed will not be called after onFailure.
// Handle websocket closure here.
// Also handle the case where failure occurs during a reconnect attempt (wasConnecting),
// where isConnected is already false but the upper layer still needs to be notified.
handleWebSocketClose(
reason = reason ?: response?.toString() ?: t.localizedMessage ?: "websocket failure",
code = response?.code ?: CLOSE_REASON_WEBSOCKET_FAILURE,
Expand Down
Loading