Skip to content

Skip diffuse commenting on 3rd party PRs #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidliu merged 1 commit into from
Mar 17, 2026
Merged

Skip diffuse commenting on 3rd party PRs #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,16 +237,22 @@ jobs:
old-file-path: client-sdk-android/diffuse-source-file
new-file-path: client-sdk-android/livekit-android-sdk-release.aar

- name: Log diffuse output
run: |
echo "Diffuse output:"
echo "${{ steps.diffuse.outputs.diff-gh-comment }}"

# Consuming diffuse action output

- uses: peter-evans/find-comment@v4
if: github.event.pull_request.head.repo.full_name == github.repository
id: find_comment
with:
issue-number: ${{ github.event.pull_request.number }}
body-includes: Diffuse output

- uses: peter-evans/create-or-update-comment@v5
if: ${{ steps.diffuse.outputs.diff-raw != null || steps.find_comment.outputs.comment-id != null }}
if: github.event.pull_request.head.repo.full_name == github.repository && (steps.diffuse.outputs.diff-raw != null || steps.find_comment.outputs.comment-id != null)
with:
body: |
Diffuse output:
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/dependency_diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,20 @@ jobs:
with:
project: 'livekit-android-sdk'

- name: Log dependency diff
run: |
echo "Dependency diff:"
echo "${{ steps.dependency-diff.outputs.text-diff }}"

- uses: peter-evans/find-comment@v4
if: github.event.pull_request.head.repo.full_name == github.repository
id: find_comment
with:
issue-number: ${{ github.event.pull_request.number }}
body-includes: Dependency diff

- uses: peter-evans/create-or-update-comment@v5
if: ${{ steps.dependency-diff.outputs.text-diff != null || steps.find_comment.outputs.comment-id != null }}
if: github.event.pull_request.head.repo.full_name == github.repository && (steps.dependency-diff.outputs.text-diff != null || steps.find_comment.outputs.comment-id != null)
with:
body: |
Dependency diff:
Expand Down
Loading