Skip to content

put ensurePublisherConnected into a try {} catch {} #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xianshijing-lk merged 2 commits into from
Mar 20, 2026
+22 −2
Merged

put ensurePublisherConnected into a try {} catch {} #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f12839f
put ensurePublisherConnected into a try {} catch {}
xianshijing-lk Mar 20, 2026
4e11ed4
fix the build
xianshijing-lk Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion livekit-android-sdk/src/main/java/io/livekit/android/room/RTCEngine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,11 @@ internal constructor(

@CheckResult
internal suspend fun sendData(dataPacket: LivekitModels.DataPacket): Result<Unit> {
ensurePublisherConnected(dataPacket.kind)
try {
ensurePublisherConnected(dataPacket.kind)
} catch (e: Exception) {
return Result.failure(e)
}

fun sendDataImpl(dataPacket: LivekitModels.DataPacket): Result<Unit> {
try {
Expand Down
18 changes: 17 additions & 1 deletion ...oid-test/src/test/java/io/livekit/android/room/participant/LocalParticipantMockE2ETest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2023-2025 LiveKit, Inc.
* Copyright 2023-2026 LiveKit, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -26,6 +26,7 @@ import io.livekit.android.events.ParticipantEvent
import io.livekit.android.events.RoomEvent
import io.livekit.android.room.DefaultsManager
import io.livekit.android.room.RTCEngine
import io.livekit.android.room.RoomException
import io.livekit.android.room.track.LocalVideoTrack
import io.livekit.android.room.track.LocalVideoTrackOptions
import io.livekit.android.room.track.ScreenSharePresets
Expand Down Expand Up @@ -879,4 +880,19 @@ class LocalParticipantMockE2ETest : MockE2ETest() {

assertTrue(headerPacket.user.payload.toByteArray().contentEquals(data))
}

@Test
fun publishDataReturnsFailureWhenPublisherChannelIsMissing() = runTest {
connect()

val rtcEngine = component.rtcEngine()
val reliableDataChannelField = RTCEngine::class.java.getDeclaredField("reliableDataChannel")
reliableDataChannelField.isAccessible = true
reliableDataChannelField.set(rtcEngine, null)

val result = room.localParticipant.publishData("hello".toByteArray())

assertTrue(result.isFailure)
assertTrue(result.exceptionOrNull() is RoomException.ConnectException)
}
}
Loading