Skip to content

bugfix: Fix the issue of incorrect connectionState status #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CMzhizhe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix: Fix the issue of incorrect connectionState status #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion livekit-android-sdk/src/main/java/io/livekit/android/room/RTCEngine.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,14 @@ internal constructor(
if (newState.isConnected()) {
connectionState = ConnectionState.CONNECTED
} else if (newState.isDisconnected()) {
connectionState = ConnectionState.DISCONNECTED
// Only transition to DISCONNECTED when not already in a reconnection
// intermediate state (RESUMING/RECONNECTING). In those states the
// reconnect flow owns connectionState; overwriting it here would
// silently swallow the disconnect and prevent the app from being notified.
val current = connectionState
if (current != ConnectionState.RESUMING && current != ConnectionState.RECONNECTING) {
connectionState = ConnectionState.DISCONNECTED
}
}
}

Expand Down
Loading