Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/set-video-dimensions
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
minor type="added" "Add setVideoDimensions for remote track publications"
31 changes: 28 additions & 3 deletions lib/src/publication/remote.dart
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import '../track/local/local.dart';
import '../track/remote/remote.dart';
import '../track/remote/video.dart';
import '../types/other.dart';
import '../types/video_dimensions.dart';
import '../utils.dart';
import 'track_publication.dart';

Expand All @@ -47,8 +48,11 @@ class RemoteTrackPublication<T extends RemoteTrack> extends TrackPublication<T>
int? _fps;
int get fps => _fps ?? 0;

VideoQuality _videoQuality = VideoQuality.HIGH;
VideoQuality get videoQuality => _videoQuality;
VideoQuality? _videoQuality = VideoQuality.HIGH;
VideoQuality get videoQuality => _videoQuality ?? VideoQuality.HIGH;

VideoDimensions? _videoDimensions;
VideoDimensions? get videoDimensions => _videoDimensions;

/// The server may pause the track when they are bandwidth limitations and resume
/// when there is more capacity. This property will be updated when the track is
Expand Down Expand Up @@ -228,6 +232,20 @@ class RemoteTrackPublication<T extends RemoteTrack> extends TrackPublication<T>
Future<void> setVideoQuality(VideoQuality newValue) async {
if (newValue == _videoQuality) return;
_videoQuality = newValue;
_videoDimensions = null;
sendUpdateTrackSettings();
}

/// Set preferred video dimensions for this track.
///
/// Server will choose the appropriate layer based on these dimensions.
/// Will override previous calls to [setVideoQuality].
Future<void> setVideoDimensions(VideoDimensions newValue) async {
if (newValue.width == _videoDimensions?.width && newValue.height == _videoDimensions?.height) {
return;
}
_videoDimensions = newValue;
_videoQuality = null;
sendUpdateTrackSettings();
}

Expand Down Expand Up @@ -300,7 +318,14 @@ class RemoteTrackPublication<T extends RemoteTrack> extends TrackPublication<T>
disabled: !_enabled,
);
if (kind == TrackType.VIDEO) {
settings.quality = _videoQuality.toPBType();
if (_videoDimensions != null) {
settings.width = _videoDimensions!.width;
settings.height = _videoDimensions!.height;
} else if (_videoQuality != null) {
settings.quality = _videoQuality!.toPBType();
} else {
settings.quality = VideoQuality.HIGH.toPBType();
}
if (_fps != null) settings.fps = _fps!;
}
participant.room.engine.signalClient.sendUpdateTrackSettings(settings);
Expand Down
Loading