Skip to content

comment out EgressInfo_Egress, move replay to livekit package #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frostbyte73 merged 5 commits into from
Mar 25, 2026
Merged

comment out EgressInfo_Egress, move replay to livekit package #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec4ade0
comment out EgressInfo_Egress
frostbyte73 Mar 25, 2026
2a81b77
move replay to livekit package
frostbyte73 Mar 25, 2026
b04863c
generated protobuf
github-actions[bot] Mar 25, 2026
8e6a88e
update magefile
frostbyte73 Mar 25, 2026
e03e962
generated protobuf
github-actions[bot] Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions egress/notify_options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ func GetEgressNotifyOptions(egressInfo *livekit.EgressInfo) []webhook.NotifyOpti
var whs []*livekit.WebhookConfig

switch req := egressInfo.Request.(type) {
case *livekit.EgressInfo_Egress:
if req.Egress != nil {
whs = req.Egress.Webhooks
}
// case *livekit.EgressInfo_Egress:
// if req.Egress != nil {
// whs = req.Egress.Webhooks
// }
Copy link
Copy Markdown
Contributor

@boks1971 boks1971 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this replaced by below?

Copy link
Copy Markdown
Contributor

@boks1971 boks1971 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, can this be deleted?

Copy link
Copy Markdown
Member Author

@frostbyte73 frostbyte73 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed temporarily - we'll use the new api only for replay at first, then add it once we're sure we don't want to make any more changes

case *livekit.EgressInfo_Replay:
if req.Replay != nil {
whs = req.Replay.Webhooks
Expand Down
99 changes: 50 additions & 49 deletions replay/cloud_replay.pb.go → livekit/cloud_replay.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading