Consolidating track-related logs#677
Open
alexlivekit wants to merge 2 commits intomainfrom
Open
Conversation
alexlivekit
commented
May 6, 2026
Contributor
Author
alexlivekit
left a comment
alexlivekit
left a comment
There was a problem hiding this comment.
- Added subscribedAt attribute to per-track logging.
- Added closedAt attribute for the "track closed" message.
- Dropped "mixing track". We can now get this info from "track closed". Forthermore, we already have the library-emitted "track subscribed", which we should ideally drop as well.
- Left the OnTrackSubscribed as a stack function for the sake of review, but this can now be easily moved to a dedicated function if we wanted to.
davidzhao
changed the title
hechen-eng
approved these changes
May 7, 2026
Contributor
hechen-eng
left a comment
hechen-eng
left a comment
There was a problem hiding this comment.
rebase and fix the CI?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.