Skip to content

[ELFDebugObjectPlugin] Gracefully handle missing section #172622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikic merged 1 commit into from
Dec 17, 2025
+10 −4
Merged

[ELFDebugObjectPlugin] Gracefully handle missing section #172622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions llvm/lib/ExecutionEngine/Orc/Debugging/ELFDebugObjectPlugin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,9 @@ Error DebugObject::visitSectionLoadAddresses(GetLoadAddressFn Callback) {
if (Name->empty())
continue;
ExecutorAddr LoadAddress = Callback(*Name);
const_cast<SectionHeader &>(Header).sh_addr =
static_cast<typename ELFT::uint>(LoadAddress.getValue());
if (LoadAddress)
const_cast<SectionHeader &>(Header).sh_addr =
static_cast<typename ELFT::uint>(LoadAddress.getValue());
}

LLVM_DEBUG({
Expand Down Expand Up @@ -267,11 +268,16 @@ void ELFDebugObjectPlugin::modifyPassConfig(MaterializationResponsibility &MR,
// section headers in our debug object allocation
Error Err = DebugObj->visitSections(
[&G, &SectionsPatched, &HasDebugSections](StringRef Name) {
Section *S = G.findSectionByName(Name);
if (!S) {
// The section may have been merged into a different one during
// linking, ignore it.
return ExecutorAddr();
}

SectionsPatched += 1;
if (isDwarfSection(Name))
HasDebugSections = true;
Section *S = G.findSectionByName(Name);
assert(S && "No graph section for object section");
return SectionRange(*S).getStart();
});

Expand Down