Honor persistent flags in proxy commands#274
Merged
Merged
Conversation
7c62d39 to
47b9d1c
Compare
Member
Author
|
Follow up from #273 (review). Cc @carole-lavillonniere Possibly worth waiting for #251 to land first. |
carole-lavillonniere
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalizes #273. Proxy commands set
DisableFlagParsing, so lstk's persistent flags were forwarded to the wrapped binary (rejected as unknown options) and their effect silently dropped.--configis broken onlstk awsthe same way--non-interactivewas — it's ignored and passed through toaws.Changes
stripGlobalFlags, which extracts--non-interactiveand--config(both--flag valueand--flag=value, in any position) from a proxy command's args. Reusable by future proxy commands; replaces the one-offstripNonInteractiveFlag.lstk awsnow setscfg.NonInteractiveso interactivity is consistent across the codebase, and routes--configback through Cobra soinitConfigresolves the overridden path instead of forwarding it toaws.Tests
TestStripGlobalFlags(both flags, both forms, interleaving, edge cases).TestAWSCommandStripsGlobalFlagsFromPassthrough— asserts both flags are consumed by lstk, not forwarded to theawsbinary.🤖 Generated with Claude Code