Make LOCALSTACK_AUTH_TOKEN take precedence over stored credentials - #415
Draft
gtsiolis wants to merge 1 commit into
Draft
Make LOCALSTACK_AUTH_TOKEN take precedence over stored credentials#415gtsiolis wants to merge 1 commit into
gtsiolis wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
gtsiolis
added
semver: patch
docs: skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stored keyring credentials used to win over
LOCALSTACK_AUTH_TOKEN, which is backwards compared with other CLIs: once you had logged in, a per-invocation token (CI secret, second account) was silently ignored until you ranlstk logout.Resolution order is now env var → keyring → browser login, in both
auth.GetTokenand the token resolution incmd/root.gothat feeds telemetry, the snapshot commands, and the container start path.lstk logoutstill removes the stored credential, and now adds a note whenLOCALSTACK_AUTH_TOKENis still set and therefore still in effect.Covered by integration tests that assert which token reaches the platform API (the precedence one fails before the fix), plus unit tests for
GetToken.Review: not needed in my view — small, single-behavior change with tests, matching the issue's stated intent. Worth a skim if you disagree that the env var should win.
Closes DEVX-1023