Repository navigation
Route sync asset I/O through reducer-issued effects - #52
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 49b05d8dd9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asset staging, upload, cache, lease and retry operations previously bypassed the sync reducer. This change makes
Core.stepthe only public producer of runner effects, seals their constructors and execution tickets, and leavesEffect_runner.submitas the public execution entry point. Direct callers now request operations through events and accept completion-derived outputs.Worker
Asset_uploadretains durable intent, graph mutation, publication acknowledgement and recovery ownership. Sync Core owns execution admission and completion identity; the runner owns I/O and the existing resource budgets. Cancelled or stale completions reclaim resources, shutdown preserves required cleanup, and distinct staging file identities prevent an old completion from deleting a replacement import. Legacy staging remains recoverable. No compatibility execution wrappers or Dune changes are included.Review follow-up indexes durable staging filenames once and makes replay bookkeeping reclaimable. Caller-held private effects remain replay-protected across GC, while completed effects no longer leave permanent scope strings in the runner.
Validation:
dune build @all app/native_embed.exe.o.6810edc:dune runtest --force(21 Alcotest suites, 593 named cases plus assertion/script regressions), rerun after the review fixes.The existing
spec-dev-tool check --allmissing-section failures in2026-09-28-bottom-lui-capsules.mdand final main's2026-10-06-timeline-soft-scroll-edge.mdremain outside this change; this decision document validates. Tests use temporary data and synthetic accounts; no real account or phone acceptance is claimed.