Skip to content

Remove retired repository artifacts and unused helpers - #55

Merged
RCmerci merged 2 commits into
mainfrom
codex/remove-reviewed-residue-20261008
Oct 8, 2026
Merged

RCmerci merged 2 commits into
mainfrom
codex/remove-reviewed-residue-20261008

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Retired review artifacts, orphan Worker fixtures and tests, and unconsumed helpers were still tracked after their callers and test lanes disappeared. This cleanup removes them and narrows local/private interfaces while retaining live native dispatch, Keychain cleanup, persistence recovery, and snapshot lifetimes.

  • Delete the entire review/ directory and three explicitly retired, unregistered Worker storage tests (372 lines, including historical unique coverage).
  • Remove obsolete oracle/admission/catalog fixtures, the orphan generator interface, the unused comparator and its Dune stanza, the empty Logical_snapshot module, and uncalled app/overlay/sync helpers.
  • Remove four generated Python bytecode files and unreachable Linux staging in the macOS-only CI job. Add bytecode ignores and require temporary review/test evidence outside the repository.
  • Remove only Overlay's direct uucp/uunf and Worker's direct base/core dependencies, with matching scoped Dune/opam metadata. Keep locked transitive dependencies and other packages' requirements.
  • Retain useful build/CI tools and registered regression coverage; fix historical references to retired review artifacts.

Total: 21 tracked files deleted across 54 changed files; 4,112 text lines deleted and 8 added (4,104 net removed), plus binary artifacts. Current tracked-tree payload falls by 1,896,838 bytes; Git history is preserved.

Validation against main fc833776d8b1aa45cd45bfd4c98c5956aa0ca635 (PR54 merge):

  • Whole-repository dune build --cache=disabled -j 2 @check, affected app/fixture libraries and generated Sync/Overlay install manifests passed.
  • All 39 non-performance registered OCaml test targets passed, including source/package boundary checks. Final Sync suite: 194 cases using synthetic localhost transport servers.
  • Worker/Overlay opam lint, Swift wrapped-key memory-only regression, asset preferences, native static GMP script and tracked Python/JSON/shell syntax checks passed.
  • Independent integrated review and git diff --check passed; both cleanup commits rebased without conflicts or content changes onto PR54.
  • Local performance test intentionally skipped to avoid competing with ongoing performance/UI validation. No local full @all host/complete-object build, live graph/account/phone/GUI or online managed-sync E2E was run.
  • spec-dev-tool check --all retains two unchanged historical document failures: bottom-lui-capsules lacks Problem/Alternatives considered/Consequences; timeline-soft-scroll-edge lacks Alternatives considered/Consequences.

Protected Dune edits match the explicitly approved scope; spec/ and locked dependency files are unchanged. Original user edits and other tasks' mutable caches/devices were preserved.

GitHub Actions Journal CI run #45 passed for exact head d06977cc3d464aa099b67919db197056245f5ec2: locked dependency installation, full dune build @all app/native_embed.exe.o, dune runtest --force, and evidence upload all succeeded. No CI repair commit was needed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T06:34:32.148457Z d06977c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit 3c8bf67 into main Oct 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant