Repository navigation
Remove retired repository artifacts and unused helpers - #55
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retired review artifacts, orphan Worker fixtures and tests, and unconsumed helpers were still tracked after their callers and test lanes disappeared. This cleanup removes them and narrows local/private interfaces while retaining live native dispatch, Keychain cleanup, persistence recovery, and snapshot lifetimes.
review/directory and three explicitly retired, unregistered Worker storage tests (372 lines, including historical unique coverage).uucp/uunfand Worker's directbase/coredependencies, with matching scoped Dune/opam metadata. Keep locked transitive dependencies and other packages' requirements.Total: 21 tracked files deleted across 54 changed files; 4,112 text lines deleted and 8 added (4,104 net removed), plus binary artifacts. Current tracked-tree payload falls by 1,896,838 bytes; Git history is preserved.
Validation against main
fc833776d8b1aa45cd45bfd4c98c5956aa0ca635(PR54 merge):dune build --cache=disabled -j 2 @check, affected app/fixture libraries and generated Sync/Overlay install manifests passed.git diff --checkpassed; both cleanup commits rebased without conflicts or content changes onto PR54.@allhost/complete-object build, live graph/account/phone/GUI or online managed-sync E2E was run.spec-dev-tool check --allretains two unchanged historical document failures: bottom-lui-capsules lacks Problem/Alternatives considered/Consequences; timeline-soft-scroll-edge lacks Alternatives considered/Consequences.Protected Dune edits match the explicitly approved scope;
spec/and locked dependency files are unchanged. Original user edits and other tasks' mutable caches/devices were preserved.GitHub Actions Journal CI run #45 passed for exact head
d06977cc3d464aa099b67919db197056245f5ec2: locked dependency installation, fulldune build @all app/native_embed.exe.o,dune runtest --force, and evidence upload all succeeded. No CI repair commit was needed.