Skip to content

Conversation

@ThierryBerger
Copy link

@ThierryBerger ThierryBerger commented Oct 8, 2025

After testing your PR locally, I realized testbeds were broken so I fixed it.

I can't push on you master as it seems you disallowed it.

As you mentioned you were a "beginner", I'll offer additional feedbacks:

  • For future PRs (on any repository), it's usually a good idea to create a branch on your repository, so you can allow modifications from targeted repository's maintainers, and also you can more easily work on different PRs in parallel :)
  • There were comments about commit hygiene, while they are correct, I'm personally most often looking at the whole diff, if there's not a particular change than I'm interested in, so don't stress about it 😄 (It's a useful thing to research and improve though)

@lukasfri
Copy link
Owner

lukasfri commented Oct 8, 2025

@ThierryBerger Thanks! Yeah I haven't dipped into a lot of open source contributing, mainly working on my own stuff so don't know the ins and outs of what people expect from general contributions, thanks for the feedback!

@lukasfri lukasfri merged commit 394257f into lukasfri:master Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants