Skip to content

Conversation

@lukasfri
Copy link
Owner

@lukasfri lukasfri commented Oct 4, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 4, 2025 20:35
@lukasfri lukasfri added the bug Something isn't working label Oct 4, 2025
@lukasfri lukasfri changed the title fix: Vec<...> never stopping with empty value fix: Vec<...> never stopping with empty value Oct 4, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a regression test to ensure deserializing into Vec properly terminates when no matching items are present, preventing non-terminating behavior.

  • Introduces a new tests::bugs module
  • Adds a not_stopping test validating Vec deserialization stops and yields an empty vector on non-matching content

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
xmlity-quick-xml/tests/features.rs Exposes the new bugs test module so it’s compiled and run.
xmlity-quick-xml/tests/bugs/not_stopping.rs Adds the regression test and minimal types needed to reproduce the issue.
xmlity-quick-xml/tests/bugs/mod.rs Declares the not_stopping test submodule.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants