This repository was archived by the owner on Aug 3, 2021. It is now read-only.
Support "2 Click Install" feature#85
Closed
idolize wants to merge 4 commits intoluludotdev:masterfrom
Closed
Conversation
Add support for external audio file uploads
This was referenced Sep 7, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Author
|
@lolPants do you have any thoughts about this? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Support for uploading custom maps without audio files to BeatSaver
requiresExternalAudioFileboolean to the beatmap metadatarequiresExternalAudioFileto true if the zip file contains audio.json and fingerprint.binrequiresExternalAudioFile, determine song length via audio.json instead of ffproberequiresExternalAudioFile, disable in-browser preview functionalityrequiresExternalAudioFile, show "bring your own song" indicator in stats areaPlatforms
This pull request modifies: (select all that apply)
Types of Changes
This pull request is contains: (select all that apply)
Checklist
Further Comments
This is part of a series of changes aimed at allowing custom maps to be created, uploaded, and used all without distributing any song file directly (instead the user must supply their own song).
luludotdev/beatmap-schemas#10
bsmg/ModAssistant#232