Skip to content

fix: the only hard coded cluster domain name within plane-ce - #249

Open
saniyar-dev wants to merge 2 commits into
makeplane:masterfrom
saniyar-dev:bugfix/hard-coded-cluster-domain
Open

fix: the only hard coded cluster domain name within plane-ce#249
saniyar-dev wants to merge 2 commits into
makeplane:masterfrom
saniyar-dev:bugfix/hard-coded-cluster-domain

Conversation

@saniyar-dev

@saniyar-dev saniyar-dev commented Jun 21, 2026

Copy link
Copy Markdown

Hi guys i wasn't sure that you want to fix the enterprise chart or not, but i was trying to install and use your apps using helm chart to get started with it and then found it this bug along the road. within the ce chart there was only in live config files and secret template that you had hard-coded domain, but there is multiple fixes needed for the enterprise.

not sure that you wanted to bump the chart version or not, but i did bumped it in this PR.

tell me if you want to fix this issue within the enterprise chart too i can extend the commits to that chart too.

Thanks for your time and your great product.

Summary by CodeRabbit

  • Chores
    • Bumped the Helm chart version from 1.5.1 to 1.5.2.
    • Updated Redis and API endpoint configuration to support a customizable cluster domain, defaulting to cluster.local.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: becacf9c-7814-40ab-9586-0fd9916e7f0b

📥 Commits

Reviewing files that changed from the base of the PR and between 45b8253 and 653ad3f.

📒 Files selected for processing (2)
  • charts/plane-ce/Chart.yaml
  • charts/plane-ce/templates/config-secrets/live-env.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • charts/plane-ce/templates/config-secrets/live-env.yaml

Walkthrough

The plane-ce chart now builds REDIS_URL and API_BASE_URL from .Values.env.default_cluster_domain, defaulting to cluster.local. The chart source entry receives a YAML indentation-only update.

Changes

Configurable Cluster Domain

Layer / File(s) Summary
Configurable URLs and chart metadata
charts/plane-ce/templates/config-secrets/live-env.yaml, charts/plane-ce/Chart.yaml
Both URLs use the configurable cluster domain. The chart source list item is reformatted without changing its URL.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: akshat5302

Poem

🐇 A rabbit hops through cluster.local,
Then finds a value more configurable.
Redis and API follow the chart,
While YAML lines stand neat and smart.
Hop, hop, the domain is set! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removing the hard-coded cluster domain from the Plane Community Edition chart.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant