Skip to content

chore(editor): use console.error in list keymap error handlers - #10194

Open
Krish6115 wants to merge 1 commit into
makeplane:previewfrom
Krish6115:chore/editor-list-keymap-console-error
Open

Krish6115 wants to merge 1 commit into
makeplane:previewfrom
Krish6115:chore/editor-list-keymap-console-error

Conversation

@Krish6115

@Krish6115 Krish6115 commented Nov 4, 2026 •

Copy link
Copy Markdown

Description

The list keymap's Delete/Backspace handlers catch errors and reported them with console.log("Error in handling ..."). Switches both to console.error so they appear as errors in the console. Behaviour is otherwise unchanged.

Type of Change

  • Code refactoring

Test Scenarios

String-level change only; type-check not run locally.

Summary by CodeRabbit

  • Bug Fixes
    • Errors encountered while handling the Delete and Backspace keys are now reported more clearly. Both keys continue to follow the same behavior after an error, so this change does not alter normal keyboard interactions.

Copilot AI balanced review requested due to automatic review settings November 4, 2026 09:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Delete and Backspace keyboard handlers now report caught errors with console.error instead of console.log. Both handlers still return false after catching an error.

Changes: List keymap error logging

Layer / File(s) Summary
Caught-error logging
packages/editor/src/extensions/custom-list-keymap/list-keymap.ts
The Delete and Backspace handlers use console.error when they catch errors. Both handlers still return false.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Possibly related PRs

  • makeplane/plane#10188: Changes failure-path logging in web work-item handlers from console.log to console.error.
  • makeplane/plane#10192: Changes failure-path logging in the Space issue-detail store from console.log to console.error.
  • makeplane/plane#10182: Removes console.log calls from an error handler and other debug logging.

Suggested reviewers: sriramveeraghanta

Merge Risk: Minimal · up to 355b9

The change reports caught keyboard-handler errors at error level without changing handler behavior. No actionable merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: replacing console.log with console.error in the editor list keymap error handlers.
Description check Passed The description explains the change, identifies the affected handlers, states that behavior is unchanged, classifies the change, and documents the test scenario. Screenshots and references are not pro…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the change, identifies the affected handlers, states that behavior is unchanged, classifies the change, and documents the test scenario. Screenshots and references are not provided, but they are not required for this change.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fe62d526-309c-4ea2-9b5f-67a82006d31c
Commits

Reviewing files that changed from the base of the PR and between 618d0eb and 355b926.

Files selected for processing: 1
  • packages/editor/src/extensions/custom-list-keymap/list-keymap.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants