Skip to content

only top 2 workers, every 30 seconds#34

Open
l-r wants to merge 2 commits into
masterfrom
less-updateShards-calls
Open

only top 2 workers, every 30 seconds#34
l-r wants to merge 2 commits into
masterfrom
less-updateShards-calls

Conversation

@l-r

@l-r l-r commented Feb 14, 2017

Copy link
Copy Markdown
Contributor

@mick 👀 do you think we need some tests around this? I was planning to throw this on some staging envs and measure the impact.

@mick

mick commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

i would be great. but is tricky to test well. If we mock describestream + make the timing configurable?

@l-r

l-r commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

Sounds good 👍 will give it a stab.

@l-r

l-r commented Feb 15, 2017

Copy link
Copy Markdown
Contributor Author

@mick whenever you have a min, could you pull this branch and tell me if you also get

# start 4th kcl
init
init
init
/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/request.js:31
            throw err;
            ^

ConditionalCheckFailedException: The conditional request failed
    at Request.extractError (/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/protocol/json.js:43:27)
    at Request.callListeners (/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
    at Request.emit (/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
    at Request.emit (/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/request.js:668:14)
    at Request.transition (/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/request.js:22:10)
    at AcceptorStateMachine.runTo (/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/state_machine.js:14:12)
    at /Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/state_machine.js:26:10
    at Request.<anonymous> (/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/request.js:38:9)
    at Request.<anonymous> (/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/request.js:670:12)
    at Request.callListeners (/Users/laurier/Documents/mapbox/kine/node_modules/aws-sdk/lib/sequential_executor.js:115:18)

@mick

mick commented Feb 15, 2017

Copy link
Copy Markdown
Contributor

@l-r yeah I also get that same error on that branch

@mick

mick commented Feb 16, 2017

Copy link
Copy Markdown
Contributor

This was because _leaseTimeout was overridden to be really short (5s) + there is nothing left to read off the stream so processRecords never gets called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants