Skip to content

Fix: Quotes around docker compose project directory argument + UTF8 docker logs #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jellever wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix: Quotes around docker compose project directory argument + UTF8 docker logs #331

jellever wants to merge 3 commits into from

Conversation

@jellever
Copy link

@jellever jellever commented Nov 26, 2025 •
edited
Loading

Small fixes:

  • Make sure docker logs are UTF8
  • Make sure docker compose --project-directory argument has quotes around it. If the path had spaces, it broke.
  • Also added quoting to project name, not sure if that one can contain spaces.
  • Added showTimeStamps parameter in container Logs extension method.
  • Bug in which 'sudo docker' was supplied as command to be executed to Executor classes that didn't proper handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jellever